changeset 65651:b16e4baf1a72

(mouse-move-drag-overlay): Fix last change.
author Stefan Monnier <monnier@iro.umontreal.ca>
date Thu, 22 Sep 2005 21:30:58 +0000
parents c30fdfca087f
children 447bc22e8322
files lisp/ChangeLog lisp/mouse.el
diffstat 2 files changed, 18 insertions(+), 6 deletions(-) [+]
line wrap: on
line diff
--- a/lisp/ChangeLog	Thu Sep 22 21:30:40 2005 +0000
+++ b/lisp/ChangeLog	Thu Sep 22 21:30:58 2005 +0000
@@ -1,11 +1,14 @@
+2005-09-22  Stefan Monnier  <monnier@iro.umontreal.ca>
+
+	* mouse.el (mouse-move-drag-overlay): Fix last change.
+
 2005-09-22  David Ponce  <david@dponce.com>
 
 	* tree-widget.el (tree-widget-value-create): Fix previous change.
 
 2005-09-21  Dan Nicolaescu  <dann@ics.uci.edu>
 
-	* term/xterm.el (terminal-init-xterm): Fix loading rxvt at run
-	time.
+	* term/xterm.el (terminal-init-xterm): Fix loading rxvt at run time.
 
 2005-09-21  Stefan Monnier  <monnier@iro.umontreal.ca>
 
@@ -117,8 +120,16 @@
 
 2005-09-18  D Goel  <deego@gnufans.org>
 
-	* apropos.el (apropos-command):
-	* textmodes/tildify.el (tildify-region):
+	* apropos.el (apropos-command): Fix `message' call: first arg
+	should be a format spec.  In this and all other cases that appear
+	below and elsewhere in the source code, I made a change only when
+	two conditions were satisfied: [1] I can think of a possibility
+	that the arguments would cause an error, for example, the code in
+	question relies on external variables such as filenames.  [2] I
+	was sure that the arg to `message' could not have been nil in the code.
+
+	* textmodes/tildify.el (tildify-region): Ditto.
+
 	* textmodes/reftex-index.el (reftex-index-change-entry)
 	(reftex-index-phrase-selection-or-word, reftex-query-index-phrase):
 	* textmodes/reftex-dcr.el (reftex-echo-ref, reftex-echo-cite):
--- a/lisp/mouse.el	Thu Sep 22 21:30:40 2005 +0000
+++ b/lisp/mouse.el	Thu Sep 22 21:30:58 2005 +0000
@@ -868,8 +868,9 @@
     ;; that a tiny move during a single-click would cause the intangible
     ;; text to be selected.
     (goto-char start)
-    (goto-char end))
-  (let ((range (mouse-start-end start (point) mode)))
+    (goto-char end)
+    (setq end (point)))
+  (let ((range (mouse-start-end start end mode)))
     (move-overlay ol (car range) (nth 1 range))))
 
 (defun mouse-drag-region-1 (start-event)