Mercurial > emacs

changeset 81992:df7b7863742c

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
(flymake-buildfile-dirs): Remove. (flymake-find-buildfile): Use locate-dominating-file.
author Stefan Monnier <monnier@iro.umontreal.ca>
date Fri, 20 Jul 2007 04:09:08 +0000
parents f41d4ecf6cb4
children 83f3a5b8e58f
files lisp/ChangeLog lisp/progmodes/flymake.el
diffstat 2 files changed, 11 insertions(+), 17 deletions(-) [+]
line wrap: on
line diff
--- a/lisp/ChangeLog	Fri Jul 20 04:00:37 2007 +0000
+++ b/lisp/ChangeLog	Fri Jul 20 04:09:08 2007 +0000
@@ -1,5 +1,8 @@
 2007-07-20  Stefan Monnier  <monnier@iro.umontreal.ca>
 
+	* progmodes/flymake.el (flymake-buildfile-dirs): Remove.
+	(flymake-find-buildfile): Use locate-dominating-file.
+
 	* vc.el (vc-delistify): Use mapconcat.
 	(vc-do-command): Minor simplification.
 	(vc-expand-dirs): Use push.
--- a/lisp/progmodes/flymake.el	Fri Jul 20 04:00:37 2007 +0000
+++ b/lisp/progmodes/flymake.el	Fri Jul 20 04:09:08 2007 +0000
@@ -325,11 +325,6 @@
   (or (nth 2 (flymake-get-file-name-mode-and-masks file-name))
       'flymake-get-real-file-name))
 
-(defcustom flymake-buildfile-dirs '("." ".." "../.." "../../.." "../../../.." "../../../../.." "../../../../../.." "../../../../../../.." "../../../../../../../.." "../../../../../../../../.." "../../../../../../../../../.." "../../../../../../../../../../..")
-  "Dirs to look for buildfile."
-  :group 'flymake
-  :type '(repeat (string)))
-
 (defvar flymake-find-buildfile-cache (flymake-makehash 'equal))
 
 (defun flymake-get-buildfile-from-cache (dir-name)
@@ -346,19 +341,15 @@
 Buildfile includes Makefile, build.xml etc.
 Return its file name if found, or nil if not found."
   (or (flymake-get-buildfile-from-cache source-dir-name)
-      (let* ((dirs flymake-buildfile-dirs)
-             (buildfile-dir          nil)
-             (found                  nil))
-        (while (and (not found) dirs)
-          (setq buildfile-dir (concat source-dir-name (car dirs)))
-          (when (file-exists-p (expand-file-name buildfile-name buildfile-dir))
-            (setq found t))
-          (setq dirs (cdr dirs)))
-        (if found
+      (let* ((file (locate-dominating-file
+                    source-dir-name
+                    (concat "\\`" (regexp-quote buildfile-name) "\\'"))))
+        (if file
             (progn
-              (flymake-log 3 "found buildfile at %s/%s" buildfile-dir buildfile-name)
-              (flymake-add-buildfile-to-cache source-dir-name buildfile-dir)
-              buildfile-dir)
+              (flymake-log 3 "found buildfile at %s" file)
+              (setq file (file-name-directory file))
+              (flymake-add-buildfile-to-cache source-dir-name file)
+              file)
           (progn
             (flymake-log 3 "buildfile for %s not found" source-dir-name)
             nil)))))