changeset 87015:eb85998bbcf9

* emacs-cvs/lisp/saveplace.el (save-place-quiet): Remove, reverting 1.39. (save-place-alist-to-file, load-save-place-alist-from-file): Don't print non-error messages at all, there's really no need. Do print if there's a problem, and clarify message in that case.
author Karl Fogel <kfogel@red-bean.com>
date Mon, 03 Dec 2007 21:37:30 +0000
parents b4495eed789b
children 178e4648e5d6
files lisp/ChangeLog lisp/saveplace.el
diffstat 2 files changed, 10 insertions(+), 15 deletions(-) [+]
line wrap: on
line diff
--- a/lisp/ChangeLog	Mon Dec 03 18:54:07 2007 +0000
+++ b/lisp/ChangeLog	Mon Dec 03 21:37:30 2007 +0000
@@ -1,3 +1,10 @@
+2007-12-03  Karl Fogel  <kfogel@red-bean.com>
+
+	* saveplace.el (save-place-quiet): Remove, reverting 1.39.
+	(save-place-alist-to-file, load-save-place-alist-from-file):
+	Don't print non-error messages at all, there's really no need.
+	Do print if there's a problem, and clarify message in that case.
+
 2007-12-03  Dan Nicolaescu  <dann@ics.uci.edu>
 
 	* ediff-util.el (ediff-setup):
--- a/lisp/saveplace.el	Mon Dec 03 18:54:07 2007 +0000
+++ b/lisp/saveplace.el	Mon Dec 03 21:37:30 2007 +0000
@@ -119,10 +119,6 @@
 on this flag."
   :type 'boolean :group 'save-place)
 
-(defcustom save-place-quiet nil
-  "If non-nil, suppress messages about loading and saving `save-place-alist'."
-  :type 'boolean :group 'save-place)
-
 (defcustom save-place-skip-check-regexp
   ;; thanks to ange-ftp-name-format
   "\\`/\\(?:cdrom\\|floppy\\|mnt\\|\\(?:[^@/:]*@\\)?[^@/:]*[^@/:.]:\\)"
@@ -212,8 +208,6 @@
   (let ((file (expand-file-name save-place-file))
         (coding-system-for-write 'utf-8))
     (save-excursion
-      (unless save-place-quiet
-        (message "Saving places to %s..." file))
       (set-buffer (get-buffer-create " *Saved Places*"))
       (delete-region (point-min) (point-max))
       (when save-place-forget-unreadable-files
@@ -233,10 +227,8 @@
 	(condition-case nil
 	    ;; Don't use write-file; we don't want this buffer to visit it.
             (write-region (point-min) (point-max) file)
-	  (file-error (message "Can't write %s" file)))
-        (kill-buffer (current-buffer))
-        (unless save-place-quiet
-          (message "Saving places to %s...done" file))))))
+	  (file-error (message "Saving places: can't write %s" file)))
+        (kill-buffer (current-buffer))))))
 
 (defun load-save-place-alist-from-file ()
   (if (not save-place-loaded)
@@ -247,8 +239,6 @@
           ;; load it if it exists:
           (if (file-readable-p file)
               (save-excursion
-                (unless save-place-quiet
-                  (message "Loading places from %s..." file))
                 ;; don't want to use find-file because we have been
                 ;; adding hooks to it.
                 (set-buffer (get-buffer-create " *Saved Places*"))
@@ -276,9 +266,7 @@
                             (setq count (1+ count)))
                           (setq s (cdr s))))))
 
-                (kill-buffer (current-buffer))
-                (unless save-place-quiet
-                  (message "Loading places from %s...done" file))))
+                (kill-buffer (current-buffer))))
           nil))))
 
 (defun save-places-to-alist ()