changeset 76258:ec75921d5b7b

(set-auto-mode-0): Use `indirect-function'. (hack-one-local-variable): Don't reapply current major mode.
author Chong Yidong <cyd@stupidchicken.com>
date Thu, 01 Mar 2007 17:06:40 +0000
parents 50979609adb0
children c3f6909185f7
files lisp/files.el
diffstat 1 files changed, 14 insertions(+), 10 deletions(-) [+]
line wrap: on
line diff
--- a/lisp/files.el	Thu Mar 01 17:06:28 2007 +0000
+++ b/lisp/files.el	Thu Mar 01 17:06:40 2007 +0000
@@ -2285,14 +2285,12 @@
 If optional arg KEEP-MODE-IF-SAME is non-nil, MODE is chased of
 any aliases and compared to current major mode.  If they are the
 same, do nothing and return nil."
-  (when keep-mode-if-same
-    (while (symbolp (symbol-function mode))
-      (setq mode (symbol-function mode)))
-    (if (eq mode major-mode)
-	(setq mode nil)))
-  (when mode
-    (funcall mode)
-    mode))
+  (unless (and keep-mode-if-same
+	       (eq (indirect-function mode)
+		   (indirect-function major-mode)))
+    (when mode
+      (funcall mode)
+      mode)))
 
 (defun set-auto-mode-1 ()
   "Find the -*- spec in the buffer.
@@ -2811,9 +2809,15 @@
 		      ok)))))))
 
 (defun hack-one-local-variable (var val)
-  "Set local variable VAR with value VAL."
+  "Set local variable VAR with value VAL.
+If VAR is `mode', call `VAL-mode' as a function unless it's
+already the major mode."
   (cond ((eq var 'mode)
-	 (funcall (intern (concat (downcase (symbol-name val)) "-mode"))))
+	 (let ((mode (intern (concat (downcase (symbol-name val))
+				     "-mode"))))
+	   (unless (eq (indirect-function mode)
+		       (indirect-function major-mode))
+	     (funcall mode))))
 	((eq var 'eval)
 	 (save-excursion (eval val)))
 	(t