comparison src/filedata.c @ 953:1e61dac76311

Cache strcmp() result.

952:77a1d5a0326d

		DEBUG_1("Change checked: no write permission: %s", fd->path);
		}

	if (fd->change->dest)
		{
		gchar *dest_dir;
		const gchar *dest_ext = extension_from_path(fd->change->dest);
		if (!dest_ext) dest_ext = "";
		
		if (strcasecmp(fd->extension, dest_ext) != 0)
			{
			ret |= CHANGE_WARN_CHANGED_EXT;
			DEBUG_1("Change checked: source and destination have different extensions: %s -> %s", fd->path, fd->change->dest);
		}

		if (fd->change->type != FILEDATA_CHANGE_UNSPECIFIED && /* FIXME this is now needed for running editors */
		    strcmp(fd->path, fd->change->dest) == 0)
			{
			ret |= CHANGE_WARN_SAME;
			DEBUG_1("Change checked: source and destination are the same: %s -> %s", fd->path, fd->change->dest);
		}

		else if (!access_file(dest_dir, W_OK))
			{
			ret |= CHANGE_NO_WRITE_PERM_DEST_DIR;
			DEBUG_1("Change checked: destination dir is readonly: %s -> %s", fd->path, fd->change->dest);
			}
		else if (isfile(fd->change->dest) && (strcmp(fd->change->dest, fd->path) != 0))
			{
			if (!access_file(fd->change->dest, W_OK))
				{
				ret |= CHANGE_NO_WRITE_PERM_DEST;
				DEBUG_1("Change checked: destination file exists and is readonly: %s -> %s", fd->path, fd->change->dest);

				{
				ret |= CHANGE_WARN_DEST_EXISTS;
				DEBUG_1("Change checked: destination exists: %s -> %s", fd->path, fd->change->dest);
				}
			}
		else if (isdir(fd->change->dest) && (strcmp(fd->change->dest, fd->path) != 0))
			{
			ret |= CHANGE_DEST_EXISTS;
			DEBUG_1("Change checked: destination exists: %s -> %s", fd->path, fd->change->dest);
			}

953:1e61dac76311

		DEBUG_1("Change checked: no write permission: %s", fd->path);
		}

	if (fd->change->dest)
		{
		gboolean same;
		gchar *dest_dir;
		const gchar *dest_ext = extension_from_path(fd->change->dest);
		if (!dest_ext) dest_ext = "";
		
		same = (strcmp(fd->path, fd->change->dest) == 0);

		if (strcasecmp(fd->extension, dest_ext) != 0)
			{
			ret |= CHANGE_WARN_CHANGED_EXT;
			DEBUG_1("Change checked: source and destination have different extensions: %s -> %s", fd->path, fd->change->dest);
		}

		if (fd->change->type != FILEDATA_CHANGE_UNSPECIFIED && /* FIXME this is now needed for running editors */
		    same)
			{
			ret |= CHANGE_WARN_SAME;
			DEBUG_1("Change checked: source and destination are the same: %s -> %s", fd->path, fd->change->dest);
		}

		else if (!access_file(dest_dir, W_OK))
			{
			ret |= CHANGE_NO_WRITE_PERM_DEST_DIR;
			DEBUG_1("Change checked: destination dir is readonly: %s -> %s", fd->path, fd->change->dest);
			}
		else if (isfile(fd->change->dest) && !same)
			{
			if (!access_file(fd->change->dest, W_OK))
				{
				ret |= CHANGE_NO_WRITE_PERM_DEST;
				DEBUG_1("Change checked: destination file exists and is readonly: %s -> %s", fd->path, fd->change->dest);

				{
				ret |= CHANGE_WARN_DEST_EXISTS;
				DEBUG_1("Change checked: destination exists: %s -> %s", fd->path, fd->change->dest);
				}
			}
		else if (isdir(fd->change->dest) && !same)
			{
			ret |= CHANGE_DEST_EXISTS;
			DEBUG_1("Change checked: destination exists: %s -> %s", fd->path, fd->change->dest);
			}