comparison mpegvideo.c @ 5836:0859108b4ae3 libavcodec

replace (disabled by default) assert(0) by abort() if the picture buffer overflows due to a buggy codec note, ive not checked if such overflows could have been exploitable before this commit

5835:74db54e5f428

        for(i=0; i<MAX_PICTURE_COUNT; i++){
            if(s->picture[i].data[0]==NULL) return i;
        }
    }

    assert(0);
    return -1;
}

static void update_noise_reduction(MpegEncContext *s){
    int intra, i;

5836:0859108b4ae3

        for(i=0; i<MAX_PICTURE_COUNT; i++){
            if(s->picture[i].data[0]==NULL) return i;
        }
    }

    av_log(s->avctx, AV_LOG_FATAL, "Internal error, picture buffer overflow\n");
    /*we could return -1 but the codec would crash anyway, trying to draw
      into, a non existing frame, this is safer than waiting for a random crash
      also the return of this is never usefull, a encoder must only allocate
      as many as allowed in the spec which has no relation to how many lavc
      could allocate (and MAX_PICTURE_COUNT is always large enough for such
      valid streams)
      and a decoder has to check stream validity and remove frames if too many
      reference frames are around. waiting for "OOM" is not correct at all, it
      similarely has to replace missing reference frames by (interpolated/MC)
      frames anything else is a bug in the codec ...
    */
    abort();
    return -1;
}

static void update_noise_reduction(MpegEncContext *s){
    int intra, i;