comparison celp_filters.c @ 9446:1a3865d1b049 libavcodec

Fix possibly harmful outbound addressing. Patch by Kenan Gillet.

9445:41245484dc0b

        int stop_on_overflow,
        int rounder)
{
    int i,n;

    // These two lines are to avoid a -1 subtraction in the main loop
    filter_length++;
    filter_coeffs--;

    for(n=0; n<buffer_length; n++)
    {
        int sum = rounder;
        for(i=1; i<filter_length; i++)
            sum -= filter_coeffs[i] * out[n-i];

        sum = (sum >> 12) + in[n];

        if(sum + 0x8000 > 0xFFFFU)
        {

        int buffer_length,
        int filter_length)
{
    int i,n;

    // These two lines are to avoid a -1 subtraction in the main loop
    filter_length++;
    filter_coeffs--;

    for(n=0; n<buffer_length; n++)
    {
        out[n] = in[n];
        for(i=1; i<filter_length; i++)
            out[n] -= filter_coeffs[i] * out[n-i];
    }
}

9446:1a3865d1b049

        int stop_on_overflow,
        int rounder)
{
    int i,n;

    // This line is to avoid a +1 subtraction in the main loop.
    filter_length++;

    for(n=0; n<buffer_length; n++)
    {
        int sum = rounder;
        for(i=1; i<filter_length; i++)
            sum -= filter_coeffs[i-1] * out[n-i];

        sum = (sum >> 12) + in[n];

        if(sum + 0x8000 > 0xFFFFU)
        {

        int buffer_length,
        int filter_length)
{
    int i,n;

    // This line is to avoid a +1 subtraction in the main loop
    filter_length++;

    for(n=0; n<buffer_length; n++)
    {
        out[n] = in[n];
        for(i=1; i<filter_length; i++)
            out[n] -= filter_coeffs[i-1] * out[n-i];
    }
}