comparison mpegvideo.c @ 5850:da358b2602ce libavcodec

Clarify comment block and rewrite in better English.

5849:c1d42c875be8

            if(s->picture[i].data[0]==NULL) return i;
        }
    }

    av_log(s->avctx, AV_LOG_FATAL, "Internal error, picture buffer overflow\n");
    /*we could return -1 but the codec would crash anyway, trying to draw
      into, a non existing frame, this is safer than waiting for a random crash
      also the return of this is never usefull, a encoder must only allocate
      as many as allowed in the spec which has no relation to how many lavc
      could allocate (and MAX_PICTURE_COUNT is always large enough for such
      valid streams)
      and a decoder has to check stream validity and remove frames if too many
      reference frames are around. waiting for "OOM" is not correct at all, it
      similarely has to replace missing reference frames by (interpolated/MC)
      frames anything else is a bug in the codec ...
    */
    abort();
    return -1;
}

static void update_noise_reduction(MpegEncContext *s){

5850:da358b2602ce

            if(s->picture[i].data[0]==NULL) return i;
        }
    }

    av_log(s->avctx, AV_LOG_FATAL, "Internal error, picture buffer overflow\n");
    /* We could return -1, but the codec would crash trying to draw into a
     * non-existing frame anyway. This is safer than waiting for a random crash.
     * Also the return of this is never useful, an encoder must only allocate
     * as much as allowed in the specification. This has no relationship to how
     * much libavcodec could allocate (and MAX_PICTURE_COUNT is always large
     * enough for such valid streams).
     * Plus, a decoder has to check stream validity and remove frames if too
     * many reference frames are around. Waiting for "OOM" is not correct at
     * all. Similarly, missing reference frames have to be replaced by
     * interpolated/MC frames, anything else is a bug in the codec ...
     */
    abort();
    return -1;
}

static void update_noise_reduction(MpegEncContext *s){