# HG changeset patch # User vitor # Date 1218057384 0 # Node ID 1d5800cec7ad5c22e91216188f19c05ac08d4271 # Parent e0e07568099658755174ba9326b0a628544962e7 Simplify eval_refl(): do not store a buffer value in a var when the buffer could be used directly diff -r e0e075680996 -r 1d5800cec7ad ra144.c --- a/ra144.c Wed Aug 06 21:04:40 2008 +0000 +++ b/ra144.c Wed Aug 06 21:16:24 2008 +0000 @@ -236,15 +236,15 @@ for (i=0; i < 10; i++) buffer2[i] = coefs[i]; - u = refl[9] = bp2[9]; + refl[9] = bp2[9]; - if (u + 0x1000 > 0x1fff) { + if ((unsigned) bp2[9] + 0x1000 > 0x1fff) { av_log(ractx, AV_LOG_ERROR, "Overflow. Broken sample?\n"); return 1; } for (c=8; c >= 0; c--) { - b = 0x1000-((u * u) >> 12); + b = 0x1000-((bp2[c+1] * bp2[c+1]) >> 12); if (!b) b = -2; @@ -252,9 +252,9 @@ for (u=0; u<=c; u++) bp1[u] = ((bp2[u] - ((refl[c+1] * bp2[c-u]) >> 12)) * (0x1000000 / b)) >> 12; - refl[c] = u = bp1[c]; + refl[c] = bp1[c]; - if ((u + 0x1000) > 0x1fff) + if ((unsigned) bp1[c] + 0x1000 > 0x1fff) return 1; FFSWAP(int *, bp1, bp2);