# HG changeset patch # User benoit # Date 1232122842 0 # Node ID 555c2ab21d845eef2e9071bb7910d30ad566b28b # Parent d90dec69b2a208f6d552028f35e52d3f83cfe78a Split ff_log_missing_feature into ff_log_missing_feature and ff_log_ask_for_sample. Patch by Kenan Gillet: gmail_adress(author) diff -r d90dec69b2a2 -r 555c2ab21d84 internal.h --- a/internal.h Fri Jan 16 02:50:20 2009 +0000 +++ b/internal.h Fri Jan 16 16:20:42 2009 +0000 @@ -36,4 +36,12 @@ */ void ff_log_missing_feature(void *avc, const char *feature, int want_sample); +/** + * Logs a generic warning message asking for a sample. + * @param[in] avc a pointer to an arbitrary struct of which the first field is + * a pointer to an AVClass struct + * @param[in] msg string containing an optional message, or NULL if no message + */ +void ff_log_ask_for_sample(void *avc, const char *msg); + #endif /* AVCODEC_INTERNAL_H */ diff -r d90dec69b2a2 -r 555c2ab21d84 qcelpdec.c --- a/qcelpdec.c Fri Jan 16 02:50:20 2009 +0000 +++ b/qcelpdec.c Fri Jan 16 16:20:42 2009 +0000 @@ -680,10 +680,7 @@ if(bitrate == SILENCE) { //FIXME: Remove experimental warning when tested with samples. - av_log(avctx, AV_LOG_WARNING, "'Blank frame handling is experimental." - " If you want to help, upload a sample " - "of this file to ftp://upload.ffmpeg.org/MPlayer/incoming/ " - "and contact the ffmpeg-devel mailing list.\n"); + ff_log_ask_for_sample(avctx, "'Blank frame handling is experimental."); } return bitrate; } diff -r d90dec69b2a2 -r 555c2ab21d84 utils.c --- a/utils.c Fri Jan 16 02:50:20 2009 +0000 +++ b/utils.c Fri Jan 16 16:20:42 2009 +0000 @@ -36,6 +36,7 @@ #include "opt.h" #include "imgconvert.h" #include "audioconvert.h" +#include "internal.h" #include #include #include @@ -1089,8 +1090,16 @@ "occurs, it means that your file has a feature which has not " "been implemented.", feature); if(want_sample) - av_log(avc, AV_LOG_WARNING, " If you want to help, upload a sample " - "of this file to ftp://upload.ffmpeg.org/MPlayer/incoming/ " - "and contact the ffmpeg-devel mailing list."); - av_log(avc, AV_LOG_WARNING, "\n"); + ff_log_ask_for_sample(avc, NULL); + else + av_log(avc, AV_LOG_WARNING, "\n"); } + +void ff_log_ask_for_sample(void *avc, const char *msg) +{ + if (msg) + av_log(avc, AV_LOG_WARNING, "%s ", msg); + av_log(avc, AV_LOG_WARNING, "If you want to help, upload a sample " + "of this file to ftp://upload.ffmpeg.org/MPlayer/incoming/ " + "and contact the ffmpeg-devel mailing list.\n"); +}