# HG changeset patch # User michael # Date 1239301311 0 # Node ID b32ece43b8a2cc3416dfdb33745f84202d9a062f # Parent 48eb9ec4e31834d47d91819a432348748df60c48 Factorize check of read symbols. diff -r 48eb9ec4e318 -r b32ece43b8a2 snow.c --- a/snow.c Thu Apr 09 15:33:02 2009 +0000 +++ b/snow.c Thu Apr 09 18:21:51 2009 +0000 @@ -3553,6 +3553,14 @@ } } +#define GET_S(dst, check) \ + tmp= get_symbol(&s->c, s->header_state, 0);\ + if(!(check)){\ + av_log(s->avctx, AV_LOG_ERROR, "Error " #dst " is %d\n", tmp);\ + return -1;\ + }\ + dst= tmp; + static int decode_header(SnowContext *s){ int plane_index, tmp; uint8_t kstate[32]; @@ -3570,10 +3578,7 @@ } if(s->keyframe){ s->version= get_symbol(&s->c, s->header_state, 0); - if(s->version>0){ - av_log(s->avctx, AV_LOG_ERROR, "version %d not supported", s->version); - return -1; - } + GET_S(s->version, tmp <= 0U) s->always_reset= get_rac(&s->c, s->header_state); s->temporal_decomposition_type= get_symbol(&s->c, s->header_state, 0); s->temporal_decomposition_count= get_symbol(&s->c, s->header_state, 0); @@ -3583,12 +3588,8 @@ s->chroma_v_shift= get_symbol(&s->c, s->header_state, 0); s->spatial_scalability= get_rac(&s->c, s->header_state); // s->rate_scalability= get_rac(&s->c, s->header_state); - tmp= get_symbol(&s->c, s->header_state, 0)+1; - if(tmp < 1 || tmp > MAX_REF_FRAMES){ - av_log(s->avctx, AV_LOG_ERROR, "reference frame count is %d\n", tmp); - return -1; - } - s->max_ref_frames= tmp; + GET_S(s->max_ref_frames, tmp < (unsigned)MAX_REF_FRAMES) + s->max_ref_frames++; decode_qlogs(s); }