# HG changeset patch # User michael # Date 1253718996 0 # Node ID b81ec4ac8f96f9e29fcec346b2a0111d54250bfb # Parent b9f5f8b8f0731302e1747693d85d9f3dbd73c90e Make sure priv_data is freed and codec is set to NULL in case of failure of avcodec_open(). diff -r b9f5f8b8f073 -r b81ec4ac8f96 utils.c --- a/utils.c Wed Sep 23 14:19:17 2009 +0000 +++ b/utils.c Wed Sep 23 15:16:36 2009 +0000 @@ -475,23 +475,20 @@ if (((avctx->coded_width || avctx->coded_height) && avcodec_check_dimensions(avctx, avctx->coded_width, avctx->coded_height)) || avctx->channels > SANE_NB_CHANNELS) { - av_freep(&avctx->priv_data); ret = AVERROR(EINVAL); - goto end; + goto free_and_end; } avctx->codec = codec; if(avctx->codec_id != codec->id || avctx->codec_type != codec->type){ av_log(avctx, AV_LOG_ERROR, "codec type or id mismatches\n"); - goto end; + goto free_and_end; } avctx->frame_number = 0; if(avctx->codec->init){ ret = avctx->codec->init(avctx); if (ret < 0) { - av_freep(&avctx->priv_data); - avctx->codec= NULL; - goto end; + goto free_and_end; } } ret=0; @@ -503,6 +500,10 @@ (*ff_lockmgr_cb)(&codec_mutex, AV_LOCK_RELEASE); } return ret; +free_and_end: + av_freep(&avctx->priv_data); + avctx->codec= NULL; + goto end; } int attribute_align_arg avcodec_encode_audio(AVCodecContext *avctx, uint8_t *buf, int buf_size,