# HG changeset patch # User michael # Date 1253659496 0 # Node ID bd1c4a438c7f0928d68e25a40d6de642e58a8f2d # Parent b783894a1c62b2c0aa4e8d2a604c32fd7b978376 Check codec_id and codec_type in avcodec_open(), based on 43_codec_type_mismatch.patch from chrome This is said to be able to lead to a stack based buffer overflow. diff -r b783894a1c62 -r bd1c4a438c7f utils.c --- a/utils.c Tue Sep 22 20:37:55 2009 +0000 +++ b/utils.c Tue Sep 22 22:44:56 2009 +0000 @@ -481,7 +481,10 @@ } avctx->codec = codec; - avctx->codec_id = codec->id; + if(avctx->codec_id != codec->id || avctx->codec_type != codec->type){ + av_log(avctx, AV_LOG_ERROR, "codec type or id mismatches\n"); + goto end; + } avctx->frame_number = 0; if(avctx->codec->init){ ret = avctx->codec->init(avctx);