# HG changeset patch # User pross # Date 1218097002 0 # Node ID d4e19b465fcbeab74e3ccc5840bfb0126d95d5e5 # Parent 11fe8c09948e459024e6ad98b4e5fa9c9d388658 Prevent DAUD PCM encoder from fetching values outside of ff_reverse[] array bounds when input sample values are < 0. diff -r 11fe8c09948e -r d4e19b465fcb pcm.c --- a/pcm.c Wed Aug 06 21:19:30 2008 +0000 +++ b/pcm.c Thu Aug 07 08:16:42 2008 +0000 @@ -209,7 +209,7 @@ break; case CODEC_ID_PCM_S24DAUD: for(;n>0;n--) { - uint32_t tmp = ff_reverse[*samples >> 8] + + uint32_t tmp = ff_reverse[(*samples >> 8) & 0xff] + (ff_reverse[*samples & 0xff] << 8); tmp <<= 4; // sync flags would go here bytestream_put_be24(&dst, tmp);