# HG changeset patch # User cehoyos # Date 1245791015 0 # Node ID ffc0f9de57439f13893278507ec51291fa24a43d # Parent 7b58b1410f48e8ecd0017e2c65a7c6bdfbdd0e96 Fix H.264 picture reordering, 2nd try. First, reverted one was r19239. Patch by Haruhiko Yamagata, h D yamagata A nifty D com diff -r 7b58b1410f48 -r ffc0f9de5743 h264.c --- a/h264.c Tue Jun 23 18:17:15 2009 +0000 +++ b/h264.c Tue Jun 23 21:03:35 2009 +0000 @@ -2240,6 +2240,7 @@ * See decode_nal_units(). */ s->current_picture_ptr->key_frame= 0; + s->current_picture_ptr->mmco_reseted= 0; assert(s->linesize && s->uvlinesize); @@ -3369,6 +3370,7 @@ h->poc_msb= h->frame_num= s->current_picture_ptr->frame_num= 0; + s->current_picture_ptr->mmco_reseted=1; break; default: assert(0); } @@ -7708,7 +7710,7 @@ //FIXME factorize this with the output code below out = h->delayed_pic[0]; out_idx = 0; - for(i=1; h->delayed_pic[i] && (h->delayed_pic[i]->poc && !h->delayed_pic[i]->key_frame); i++) + for(i=1; h->delayed_pic[i] && !h->delayed_pic[i]->key_frame && !h->delayed_pic[i]->mmco_reseted; i++) if(h->delayed_pic[i]->poc < out->poc){ out = h->delayed_pic[i]; out_idx = i; @@ -7884,12 +7886,12 @@ out = h->delayed_pic[0]; out_idx = 0; - for(i=1; h->delayed_pic[i] && (h->delayed_pic[i]->poc && !h->delayed_pic[i]->key_frame); i++) + for(i=1; h->delayed_pic[i] && !h->delayed_pic[i]->key_frame && !h->delayed_pic[i]->mmco_reseted; i++) if(h->delayed_pic[i]->poc < out->poc){ out = h->delayed_pic[i]; out_idx = i; } - cross_idr = !h->delayed_pic[0]->poc || !!h->delayed_pic[i] || h->delayed_pic[0]->key_frame; + cross_idr = !!h->delayed_pic[i] || h->delayed_pic[0]->key_frame || h->delayed_pic[0]->mmco_reseted; out_of_order = !cross_idr && out->poc < h->outputed_poc; diff -r 7b58b1410f48 -r ffc0f9de5743 mpegvideo.h --- a/mpegvideo.h Tue Jun 23 18:17:15 2009 +0000 +++ b/mpegvideo.h Tue Jun 23 21:03:35 2009 +0000 @@ -116,6 +116,7 @@ int field_poc[2]; ///< h264 top/bottom POC int poc; ///< h264 frame POC int frame_num; ///< h264 frame_num (raw frame_num from slice header) + int mmco_reseted; ///< h264 MMCO_RESET set this 1. Reordering code must not mix pictures before and after MMCO_RESET. int pic_id; /**< h264 pic_num (short -> no wrap version of pic_num, pic_num & max_pic_num; long -> long_pic_num) */ int long_ref; ///< 1->long term reference 0->short term reference