Mercurial > libavcodec.hg

changeset 11403:128f82b41fc1 libavcodec

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
Make Indeo 5 decoder more robust on bitstream errors. Patch by Maxim ($indeo5dec_author)
author kostya
date Mon, 08 Mar 2010 06:52:33 +0000
parents 43ae6b3f9e15
children a744eb5328b2
files indeo5.c
diffstat 1 files changed, 8 insertions(+), 4 deletions(-) [+]
line wrap: on
line diff
--- a/indeo5.c	Mon Mar 08 06:49:16 2010 +0000
+++ b/indeo5.c	Mon Mar 08 06:52:33 2010 +0000
@@ -549,7 +549,7 @@
 static int decode_band(IVI5DecContext *ctx, int plane_num,
                        IVIBandDesc *band, AVCodecContext *avctx)
 {
-    int         result, i, t, idx1, idx2;
+    int         result, i, t, idx1, idx2, pos;
     IVITile     *tile;
 
     band->buf     = band->bufs[ctx->dst_buf];
@@ -590,6 +590,8 @@
         FFSWAP(int16_t, band->rv_map->valtab[idx1], band->rv_map->valtab[idx2]);
     }
 
+    pos = get_bits_count(&ctx->gb);
+
     for (t = 0; t < band->num_tiles; t++) {
         tile = &band->tiles[t];
 
@@ -597,7 +599,6 @@
         if (tile->is_empty) {
             ff_ivi_process_empty_tile(avctx, band, tile,
                                       (ctx->planes[0].bands[0].mb_size >> 3) - (band->mb_size >> 3));
-            align_get_bits(&ctx->gb);
         } else {
             tile->data_size = ff_ivi_dec_tile_data_size(&ctx->gb);
 
@@ -606,10 +607,11 @@
                 break;
 
             result = ff_ivi_decode_blocks(&ctx->gb, band, tile);
-            if (result < 0) {
-                av_log(avctx, AV_LOG_ERROR, "Corrupted blocks data encountered!\n");
+            if (result < 0 || (get_bits_count(&ctx->gb) - pos) >> 3 != tile->data_size) {
+                av_log(avctx, AV_LOG_ERROR, "Corrupted tile data encountered!\n");
                 break;
             }
+            pos += tile->data_size << 3; // skip to next tile
         }
     }
 
@@ -632,6 +634,8 @@
     }
 #endif
 
+    align_get_bits(&ctx->gb);
+
     return result;
 }