comparison metadata.c @ 4353:e4a1b568b313 libavformat

modify the way to pass parameters to av_metadata_set() This improves code readability and this avoid warnings about discarding qualifiers from pointer target type.

4352:817bef131f7f

        return &m->elems[i];
    }
    return NULL;
}

int av_metadata_set(AVMetadata **pm, AVMetadataTag elem)
{
    AVMetadata *m= *pm;
    AVMetadataTag *tag= av_metadata_get(m, elem.key, NULL, AV_METADATA_MATCH_CASE);

    if(!m)
        m=*pm= av_mallocz(sizeof(*m));

    if(tag){

        if(tmp){
            m->elems= tmp;
        }else
            return AVERROR(ENOMEM);
    }
    if(elem.value){
        elem.key  = av_strdup(elem.key  );
        elem.value= av_strdup(elem.value);
        m->elems[m->count++]= elem;
    }
    if(!m->count)
        av_freep(pm);

    return 0;

4353:e4a1b568b313

        return &m->elems[i];
    }
    return NULL;
}

int av_metadata_set(AVMetadata **pm, const char *key, const char *value)
{
    AVMetadata *m= *pm;
    AVMetadataTag *tag= av_metadata_get(m, key, NULL, AV_METADATA_MATCH_CASE);

    if(!m)
        m=*pm= av_mallocz(sizeof(*m));

    if(tag){

        if(tmp){
            m->elems= tmp;
        }else
            return AVERROR(ENOMEM);
    }
    if(value){
        m->elems[m->count].key  = av_strdup(key  );
        m->elems[m->count].value= av_strdup(value);
        m->count++;
    }
    if(!m->count)
        av_freep(pm);

    return 0;