# HG changeset patch # User rbultje # Date 1229204247 0 # Node ID 233ba738a68e08a89a0f36e0dd5ee6d62d123cf7 # Parent 27f4b31bc790db7b210f36ed229d4b75102ee978 Don't access RMContext directly in rdt.c. Rather, use the return value of ff_rm_parse_packet() to indicate whether more audio packets are available in the demuxer from the last RM frame, and save that in the RDT parsing context. See patch/discussion in "[PATCH] rdt.c: don't access RMContext" on ML. diff -r 27f4b31bc790 -r 233ba738a68e rdt.c --- a/rdt.c Sat Dec 13 17:18:11 2008 +0000 +++ b/rdt.c Sat Dec 13 21:37:27 2008 +0000 @@ -84,6 +84,7 @@ uint8_t *mlti_data; unsigned int mlti_data_size; char buffer[RTP_MAX_PACKET_LENGTH + FF_INPUT_BUFFER_PADDING_SIZE]; + int audio_pkt_cnt[MAX_STREAMS]; /**< remaining audio packets in rmdec */ }; void @@ -294,9 +295,8 @@ { int seq = 1, res; ByteIOContext pb; - RMContext *rm = rdt->rmctx->priv_data; - if (rm->audio_pkt_cnt == 0) { + if (rdt->audio_pkt_cnt == 0) { int pos; init_put_byte(&pb, buf, len, 0, NULL, NULL, NULL, NULL); @@ -306,7 +306,8 @@ pos = url_ftell(&pb); if (res < 0) return res; - if (rm->audio_pkt_cnt > 0 && + rdt->audio_pkt_cnt[st->id] = res; + if (rdt->audio_pkt_cnt[st->id] > 0 && st->codec->codec_id == CODEC_ID_AAC) { memcpy (rdt->buffer, buf + pos, len - pos); rdt->rmctx->pb = av_alloc_put_byte (rdt->buffer, len - pos, 0, @@ -314,14 +315,14 @@ } } else { ff_rm_retrieve_cache (rdt->rmctx, rdt->rmctx->pb, st, pkt); - if (rm->audio_pkt_cnt == 0 && + if (rdt->audio_pkt_cnt[st->id] == 0 && st->codec->codec_id == CODEC_ID_AAC) av_freep(&rdt->rmctx->pb); } pkt->stream_index = st->index; pkt->pts = *timestamp; - return rm->audio_pkt_cnt > 0; + return rdt->audio_pkt_cnt[st->id] > 0; } int diff -r 27f4b31bc790 -r 233ba738a68e rm.h --- a/rm.h Sat Dec 13 17:18:11 2008 +0000 +++ b/rm.h Sat Dec 13 21:37:27 2008 +0000 @@ -93,7 +93,9 @@ * @param flags pointer to an integer containing the packet flags, may be updated * @param ts pointer to timestamp, may be updated - * @return 0 on success, errno codes on error + * @return >=0 on success (where >0 indicates there are cached samples that + * can be retrieved with subsequent calls to ff_rm_retrieve_cache()), + * errno codes on error */ int ff_rm_parse_packet (AVFormatContext *s, ByteIOContext *pb, AVStream *st, int len, diff -r 27f4b31bc790 -r 233ba738a68e rmdec.c --- a/rmdec.c Sat Dec 13 17:18:11 2008 +0000 +++ b/rmdec.c Sat Dec 13 21:37:27 2008 +0000 @@ -644,7 +644,7 @@ if (*flags & 2) pkt->flags |= PKT_FLAG_KEY; - return 0; + return st->codec->codec_type == CODEC_TYPE_AUDIO ? rm->audio_pkt_cnt : 0; } void