# HG changeset patch # User bindhammer # Date 1283238911 0 # Node ID 3a28e68270950e8a7291085e8aa2ad36a1e264f0 # Parent 4775a49a60450d25314baf1cd965970c39873dab Solving memory leak and initialization problem with prev_pkt / pkt. diff -r 4775a49a6045 -r 3a28e6827095 a64.c --- a/a64.c Mon Aug 30 23:16:35 2010 +0000 +++ b/a64.c Tue Aug 31 07:15:11 2010 +0000 @@ -125,8 +125,16 @@ } /* backup current packet for next turn */ if(pkt->data) { - av_new_packet(&c->prev_pkt, pkt->size); - memcpy(c->prev_pkt.data, pkt->data, pkt->size); + /* no backup packet yet? create one! */ + if(!c->prev_pkt.data) av_new_packet(&c->prev_pkt, pkt->size); + /* we have a packet and data is big enough, reuse it */ + if(c->prev_pkt.data && c->prev_pkt.size >= pkt->size) { + memcpy(c->prev_pkt.data, pkt->data, pkt->size); + c->prev_pkt.size = pkt->size; + } else { + av_log(avctx, AV_LOG_ERROR, "Too less memory for prev_pkt.\n"); + return AVERROR(ENOMEM); + } } c->prev_frame_count = frame_count; break; @@ -145,9 +153,11 @@ static int a64_write_trailer(struct AVFormatContext *s) { A64MuxerContext *c = s->priv_data; - AVPacket pkt; + AVPacket pkt = {0}; /* need to flush last packet? */ if(c->interleaved) a64_write_packet(s, &pkt); + /* discard backed up packet */ + if(c->prev_pkt.data) av_destruct_packet(&c->prev_pkt); return 0; }