# HG changeset patch # User mstorsjo # Date 1285100254 0 # Node ID 3e7384f85f1ddc3c7ccdaeedc7f317472a1e3dd8 # Parent 1e6ebac87d447a1913b549854209f9d998685041 tcp: Check both wfds and efds when waiting for the result from connect On windows, a connection failure doesn't trigger wfds as it does on unix. This fixes issue 2237, based on code by yeyingxian. diff -r 1e6ebac87d44 -r 3e7384f85f1d tcp.c --- a/tcp.c Mon Sep 20 06:38:40 2010 +0000 +++ b/tcp.c Tue Sep 21 20:17:34 2010 +0000 @@ -38,7 +38,7 @@ struct addrinfo hints, *ai, *cur_ai; int port, fd = -1; TCPContext *s = NULL; - fd_set wfds; + fd_set wfds, efds; int fd_max, ret; struct timeval tv; socklen_t optlen; @@ -87,11 +87,13 @@ } fd_max = fd; FD_ZERO(&wfds); + FD_ZERO(&efds); FD_SET(fd, &wfds); + FD_SET(fd, &efds); tv.tv_sec = 0; tv.tv_usec = 100 * 1000; - ret = select(fd_max + 1, NULL, &wfds, NULL, &tv); - if (ret > 0 && FD_ISSET(fd, &wfds)) + ret = select(fd_max + 1, NULL, &wfds, &efds, &tv); + if (ret > 0 && (FD_ISSET(fd, &wfds) || FD_ISSET(fd, &efds))) break; }