# HG changeset patch # User mstorsjo # Date 1275597089 0 # Node ID 54d3a9240339a87e754715599af830f6bf5398db # Parent 403c73d966e2b92334abed95014283f6c0bd77f4 httpauth: Fix the length passed to av_strlcat Since the buffer always was large enough, this bug didn't have any effect in practice. diff -r 403c73d966e2 -r 54d3a9240339 httpauth.c --- a/httpauth.c Thu Jun 03 16:51:29 2010 +0000 +++ b/httpauth.c Thu Jun 03 20:31:29 2010 +0000 @@ -303,7 +303,7 @@ snprintf(authstr, len, "Authorization: Basic "); ptr = authstr + strlen(authstr); av_base64_encode(ptr, auth_b64_len, auth, strlen(auth)); - av_strlcat(ptr, "\r\n", len); + av_strlcat(ptr, "\r\n", len - (ptr - authstr)); } else if (state->auth_type == HTTP_AUTH_DIGEST) { char *username = av_strdup(auth), *password;