# HG changeset patch # User jbr # Date 1269295118 0 # Node ID 92daebc423f4cfc948b995900c8581ee6c0815ae # Parent b5d74258cd23b67a415800bf58789c9929116648 Move ff_flac_write_header() to flacenc.h, which removes the Matroska muxer's dependency on flacenc.o and fixes the unnecessary dependency on vorbiscomment.o. diff -r b5d74258cd23 -r 92daebc423f4 Makefile --- a/Makefile Mon Mar 22 20:18:42 2010 +0000 +++ b/Makefile Mon Mar 22 21:58:38 2010 +0000 @@ -103,7 +103,7 @@ OBJS-$(CONFIG_MATROSKA_DEMUXER) += matroskadec.o matroska.o \ riff.o isom.o rmdec.o rm.o OBJS-$(CONFIG_MATROSKA_MUXER) += matroskaenc.o matroska.o \ - riff.o isom.o avc.o flacenc.o + riff.o isom.o avc.o OBJS-$(CONFIG_MJPEG_DEMUXER) += raw.o OBJS-$(CONFIG_MJPEG_MUXER) += raw.o OBJS-$(CONFIG_MLP_DEMUXER) += raw.o id3v2.o diff -r b5d74258cd23 -r 92daebc423f4 flacenc.c --- a/flacenc.c Mon Mar 22 20:18:42 2010 +0000 +++ b/flacenc.c Mon Mar 22 21:58:38 2010 +0000 @@ -26,29 +26,6 @@ #include "vorbiscomment.h" #include "libavcodec/bytestream.h" -int ff_flac_write_header(ByteIOContext *pb, AVCodecContext *codec, - int last_block) -{ - uint8_t header[8] = { - 0x66, 0x4C, 0x61, 0x43, 0x00, 0x00, 0x00, 0x22 - }; - uint8_t *streaminfo; - enum FLACExtradataFormat format; - - header[4] = last_block ? 0x80 : 0x00; - if (!ff_flac_is_extradata_valid(codec, &format, &streaminfo)) - return -1; - - /* write "fLaC" stream marker and first metadata block header if needed */ - if (format == FLAC_EXTRADATA_FORMAT_STREAMINFO) { - put_buffer(pb, header, 8); - } - - /* write STREAMINFO or full header */ - put_buffer(pb, codec->extradata, codec->extradata_size); - - return 0; -} static int flac_write_block_padding(ByteIOContext *pb, unsigned int n_padding_bytes, int last_block) diff -r b5d74258cd23 -r 92daebc423f4 flacenc.h --- a/flacenc.h Mon Mar 22 20:18:42 2010 +0000 +++ b/flacenc.h Mon Mar 22 21:58:38 2010 +0000 @@ -22,9 +22,32 @@ #ifndef AVFORMAT_FLACENC_H #define AVFORMAT_FLACENC_H +#include "libavcodec/flac.h" +#include "libavcodec/bytestream.h" #include "avformat.h" -int ff_flac_write_header(ByteIOContext *pb, AVCodecContext *codec, - int last_block); +static int ff_flac_write_header(ByteIOContext *pb, AVCodecContext *codec, + int last_block) +{ + uint8_t header[8] = { + 0x66, 0x4C, 0x61, 0x43, 0x00, 0x00, 0x00, 0x22 + }; + uint8_t *streaminfo; + enum FLACExtradataFormat format; + + header[4] = last_block ? 0x80 : 0x00; + if (!ff_flac_is_extradata_valid(codec, &format, &streaminfo)) + return -1; + + /* write "fLaC" stream marker and first metadata block header if needed */ + if (format == FLAC_EXTRADATA_FORMAT_STREAMINFO) { + put_buffer(pb, header, 8); + } + + /* write STREAMINFO or full header */ + put_buffer(pb, codec->extradata, codec->extradata_size); + + return 0; +} #endif /* AVFORMAT_FLACENC_H */