# HG changeset patch # User mstorsjo # Date 1276503839 0 # Node ID a972e847775b299f3cc72441628c51c972579ed5 # Parent fec869707e4fd3a2a9a29e9ab316872ed4169800 RTSP: Shrink SDP fmtp parsing buffer size Since the parsing of Vorbis/Theora fmtp headers is handled by the parse_sdp_a_line function pointer now, the buffer in sdp_parse_fmtp doesn't need to be this large any longer. Patch by Josh Allmann, joshua dot allmann at gmail diff -r fec869707e4f -r a972e847775b rtsp.c --- a/rtsp.c Mon Jun 14 08:12:40 2010 +0000 +++ b/rtsp.c Mon Jun 14 08:23:59 2010 +0000 @@ -273,9 +273,7 @@ static void sdp_parse_fmtp(AVStream *st, const char *p) { char attr[256]; - /* Vorbis setup headers can be up to 12KB and are sent base64 - * encoded, giving a 12KB * (4/3) = 16KB FMTP line. */ - char value[16384]; + char value[4096]; int i; RTSPStream *rtsp_st = st->priv_data; AVCodecContext *codec = st->codec; @@ -541,7 +539,8 @@ * "rulebooks" describing their properties. Therefore, the SDP line * buffer is large. * - * The Vorbis FMTP line can be up to 16KB - see sdp_parse_fmtp. */ + * The Vorbis FMTP line can be up to 16KB - see xiph_parse_sdp_line + * in rtpdec_xiph.c. */ char buf[16384], *q; SDPParseState sdp_parse_state, *s1 = &sdp_parse_state;