comparison random_seed.c @ 964:08c117c60753 libavutil

random_seed: allow to block on /dev/random If both /dev/random and /dev/urandom failed to return data, an uninitialised value might be returned. Since most systems have a non-blocking /dev/urandom or have /dev/random with similar properties, the chance of blocking is minimal, and the alternative of returning non-random data is worse.

963:bb7159d1f769

    int fd = open(file, O_RDONLY);
    int err = -1;

    if (fd == -1)
        return -1;
#if HAVE_FCNTL && defined(O_NONBLOCK)
    if (fcntl(fd, F_SETFL, fcntl(fd, F_GETFL) | O_NONBLOCK) != -1)
#endif
        err = read(fd, dst, sizeof(*dst));
    close(fd);

    return err;
}

964:08c117c60753

    int fd = open(file, O_RDONLY);
    int err = -1;

    if (fd == -1)
        return -1;
        err = read(fd, dst, sizeof(*dst));
    close(fd);

    return err;
}