# HG changeset patch # User michael # Date 1199469136 0 # Node ID a54e20281de9f00587d2e74c27dd5d56b61bd39d # Parent 357ac44f47208ee25475bebce8a18ba03b74ae58 Move *malloc() out of tree.c, that way the code can be used with flat arrays which have lower overhead than millions of mallocd() elements. diff -r 357ac44f4720 -r a54e20281de9 tree.c --- a/tree.c Fri Jan 04 10:14:21 2008 +0000 +++ b/tree.c Fri Jan 04 17:52:16 2008 +0000 @@ -28,6 +28,8 @@ int state; }AVTreeNode; +const int av_tree_node_size = sizeof(AVTreeNode); + void *av_tree_find(const AVTreeNode *t, void *key, int (*cmp)(void *key, const void *b), void *next[2]){ if(t){ unsigned int v= cmp(t->elem, key); @@ -45,14 +47,14 @@ return NULL; } -void *av_tree_insert(AVTreeNode **tp, void *key, int (*cmp)(void *key, const void *b)){ +void *av_tree_insert(AVTreeNode **tp, void *key, int (*cmp)(void *key, const void *b), AVTreeNode **next){ AVTreeNode *t= *tp; if(t){ unsigned int v= cmp(t->elem, key); if(v){ int i= v>>31; AVTreeNode **child= &t->child[i]; - void *ret= av_tree_insert(child, key, cmp); + void *ret= av_tree_insert(child, key, cmp, next); if(!ret){ t->state -= ((int)v>>31)|1; if(!(t->state&1)){ @@ -83,7 +85,7 @@ return t->elem; } }else{ - *tp= av_mallocz(sizeof(AVTreeNode)); + *tp= *next; *next= NULL; (*tp)->elem= key; return NULL; } diff -r 357ac44f4720 -r a54e20281de9 tree.h --- a/tree.h Fri Jan 04 10:14:21 2008 +0000 +++ b/tree.h Fri Jan 04 17:52:16 2008 +0000 @@ -28,6 +28,7 @@ #define FFMPEG_TREE_H struct AVTreeNode; +extern const int av_tree_node_size; /** * Finds an element. @@ -46,13 +47,22 @@ * @param rootp A pointer to a pointer to the root node of the tree. Note that * the root node can change during insertions, this is required * to keep the tree balanced. + * @param next AVTreeNode used for the inserted element, must be allocated and + * zeroed by the user. And will be set to NULL if used by + * av_tree_insert(). This allows the use of flat arrays, which have + * lower overhead compared to many malloced elements. + * You might want to define a function like: + * void *tree_insert(struct AVTreeNode **rootp, void *key, int (*cmp)(void *key, const void *b), AVTreeNode **next){ + * if(!*next) *next= av_mallocz(av_tree_node_size); + * return av_tree_insert(rootp, key, cmp, next); + * } * * @return If no insertion happened, the found element. * If an insertion happened, then either key or NULL will be returned. * Which one it is depends on the tree state and the implementation. You * should make no assumptions that it's one or the other in the code. */ -void *av_tree_insert(struct AVTreeNode **rootp, void *key, int (*cmp)(void *key, const void *b)); +void *av_tree_insert(struct AVTreeNode **rootp, void *key, int (*cmp)(void *key, const void *b), struct AVTreeNode **next); void av_tree_destroy(struct AVTreeNode *t); #endif /* FFMPEG_TREE_H */