comparison navigation.c @ 434:264c5b900bfb src

Pass return value of vm_jump_up back to the caller. dvdnav_go_up ignores the return value of vm_jump_up, and always returns DVDNAV_STATUS_OK, the calling code cannot therefore determine whether the jump was successful or not. The attached patch evaluates the return value from vm_jump_up and passes this back to the caller. Patch by Richard Hulme.

433:1c7c804e9c82

  return DVDNAV_STATUS_OK;
}

dvdnav_status_t dvdnav_go_up(dvdnav_t *this) {
  /* A nice easy function... delegate to the VM */
  pthread_mutex_lock(&this->vm_lock);
  vm_jump_up(this->vm);
  pthread_mutex_unlock(&this->vm_lock);

  return DVDNAV_STATUS_OK;
}

434:264c5b900bfb

  return DVDNAV_STATUS_OK;
}

dvdnav_status_t dvdnav_go_up(dvdnav_t *this) {
  /* A nice easy function... delegate to the VM */
  int32_t retval;

  pthread_mutex_lock(&this->vm_lock);
  retval = vm_jump_up(this->vm);
  pthread_mutex_unlock(&this->vm_lock);

  return retval ? DVDNAV_STATUS_OK : DVDNAV_STATUS_ERR;
}