# HG changeset patch # User rathann # Date 1381096586 0 # Node ID 264c5b900bfb134451990077725b625449fe20b5 # Parent 1c7c804e9c82fb62f5d6f0c3d33a832e2d8e29da Pass return value of vm_jump_up back to the caller. dvdnav_go_up ignores the return value of vm_jump_up, and always returns DVDNAV_STATUS_OK, the calling code cannot therefore determine whether the jump was successful or not. The attached patch evaluates the return value from vm_jump_up and passes this back to the caller. Patch by Richard Hulme. diff -r 1c7c804e9c82 -r 264c5b900bfb navigation.c --- a/navigation.c Sun Oct 06 20:54:43 2013 +0000 +++ b/navigation.c Sun Oct 06 21:56:26 2013 +0000 @@ -268,9 +268,11 @@ dvdnav_status_t dvdnav_go_up(dvdnav_t *this) { /* A nice easy function... delegate to the VM */ + int32_t retval; + pthread_mutex_lock(&this->vm_lock); - vm_jump_up(this->vm); + retval = vm_jump_up(this->vm); pthread_mutex_unlock(&this->vm_lock); - return DVDNAV_STATUS_OK; + return retval ? DVDNAV_STATUS_OK : DVDNAV_STATUS_ERR; }