# HG changeset patch # User rathann # Date 1384818196 0 # Node ID 9f5802d2767a23ab7c26a9a4fa60d7f3d6b75094 # Parent 42d169fbee1d2ae9048469cf727669962909bf99 Free `cached_dir_base` to fix memory leak The static analyzer from LLVM/Clang 1:3.4~svn194079-1 reports a memory leak in `libdvdread/src/dvd_udf.c`. $ scan-build -o scan-build make $ scan-view scan-build/2013-11-18-155601-16168-1 The memory is allocated in if((cached_dir_base = malloc(dir_lba * DVD_VIDEO_LB_LEN + 2048)) == NULL) and has to be freed before returning from the function. Signed-off-by: Paul Menzel diff -r 42d169fbee1d -r 9f5802d2767a dvd_udf.c --- a/dvd_udf.c Sun Nov 17 00:16:02 2013 +0000 +++ b/dvd_udf.c Mon Nov 18 23:43:16 2013 +0000 @@ -594,8 +594,10 @@ } else in_cache = 1; - if(cached_dir == NULL) + if(cached_dir == NULL) { + free(cached_dir_base); return 0; + } p = 0;