Mercurial > libdvdread4.hg

changeset 90:9f5802d2767a src

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
Free `cached_dir_base` to fix memory leak The static analyzer from LLVM/Clang 1:3.4~svn194079-1 reports a memory leak in `libdvdread/src/dvd_udf.c`. $ scan-build -o scan-build make $ scan-view scan-build/2013-11-18-155601-16168-1 The memory is allocated in if((cached_dir_base = malloc(dir_lba * DVD_VIDEO_LB_LEN + 2048)) == NULL) and has to be freed before returning from the function. Signed-off-by: Paul Menzel <paulepanter@users.sourceforge.net>
author rathann
date Mon, 18 Nov 2013 23:43:16 +0000
parents 42d169fbee1d
children 23d412d59d62
files dvd_udf.c
diffstat 1 files changed, 3 insertions(+), 1 deletions(-) [+]
line wrap: on
line diff
--- a/dvd_udf.c	Sun Nov 17 00:16:02 2013 +0000
+++ b/dvd_udf.c	Mon Nov 18 23:43:16 2013 +0000
@@ -594,8 +594,10 @@
     } else
       in_cache = 1;
 
-    if(cached_dir == NULL)
+    if(cached_dir == NULL) {
+      free(cached_dir_base);
       return 0;
+    }
 
     p = 0;