|
2200
|
1
|
|
|
2 About CVS write access: by A'rpi
|
|
|
3 ~~~~~~~~~~~~~~~~~~~~~~~
|
|
|
4
|
|
|
5 I. TECH SIDE:
|
|
|
6 =============
|
|
|
7 1. Changing password:
|
|
|
8
|
|
|
9 As you probably got a restricted CVS-only shell, it's not trivial:
|
|
|
10
|
|
|
11 ssh LOGIN@mplayerhq.hu passwd
|
|
|
12
|
|
|
13 (replace LOGIN with your loginname. leave 'passwd' unchanged, it's command)
|
|
|
14
|
|
|
15 Note: if you need real shell for something, tell me.
|
|
|
16
|
|
|
17 2. Checkout devel. source tree:
|
|
|
18
|
|
|
19 export CVS_RSH=ssh
|
|
|
20 cvs -z3 -d:ext:LOGIN@mplayerhq.hu:/cvsroot/mplayer co main
|
|
|
21
|
|
3149
|
22 NOTE: cvs -d:pserver: mode doesn't allow writting, even with password!
|
|
|
23
|
|
2200
|
24 3. Commiting changes:
|
|
|
25
|
|
|
26 cvs -z3 commit -m "comment - what and why did you change" filename(s)
|
|
|
27
|
|
3149
|
28 Do not use such comments: "bugfix." or "files changed" or "dunno"
|
|
|
29 You don't have to include filename in comment, as comments are linked
|
|
|
30 to files. If you have different comments for files, commit them separated,
|
|
|
31 not at same time.
|
|
|
32
|
|
2200
|
33 4. Adding new files/dirs:
|
|
|
34
|
|
|
35 cvs add filename/dirname
|
|
|
36
|
|
|
37 5. Removing files:
|
|
|
38
|
|
|
39 rm filename
|
|
|
40 cvs remove filename
|
|
|
41
|
|
|
42 6. Check changes:
|
|
|
43
|
|
|
44 cvs -z3 diff -u filename(s)
|
|
|
45
|
|
3149
|
46 it's recommended to check changes first, before commit. especially if you
|
|
|
47 forget what did you change :)
|
|
|
48 and this way you will see if your patch has debug stuff or indenting change,
|
|
|
49 and you can fix it before commiting and triggering me to use cvs-backup.
|
|
|
50
|
|
2200
|
51 7. Check changelog:
|
|
|
52
|
|
|
53 cvs -z3 log filename(s)
|
|
|
54
|
|
|
55 8. Rename/move files:
|
|
|
56
|
|
3149
|
57 you can NOT do that. ask CVS server admin (A'rpi) to do it!
|
|
|
58 do NOT remove & re-add file - it will kill changelog!!!!
|
|
2200
|
59
|
|
|
60 If you have any tech problems with cvs server, contact me:
|
|
|
61 A'rpi <arpi@thot.banki.hu>
|
|
|
62
|
|
|
63
|
|
|
64 II. POLICY / RULES:
|
|
|
65 ===================
|
|
|
66
|
|
|
67 1. You shouldn't commit code which makes cvs broken!
|
|
|
68 (i mean unfinished but enabled code which break
|
|
|
69 compiling or compiles but does not work)
|
|
|
70
|
|
|
71 2. You don't have over-test things. if it works for you,
|
|
|
72 and you think it should work for others too, then commit.
|
|
|
73 If it has problems (portability, exploits compiler bugs,
|
|
|
74 unusual environment etc) they will be reported, it's ok.
|
|
|
75
|
|
|
76 3. You can commit unfinished stuff (for testing etc), but it
|
|
|
77 must be disabled (#ifdef etc) by default.
|
|
|
78
|
|
|
79 4. Do not change behaviour of the program (renaming options etc)
|
|
|
80 without discussing first at the MPlayer-dev-eng list.
|
|
|
81
|
|
|
82 5. Source indenting and other cosmetical changes are refused.
|
|
|
83 I'll remove those commits...
|
|
|
84 Every developer has its own indenting style, you shouldn't
|
|
|
85 change it. Of course if you (re)write something then you can
|
|
|
86 use your own style...
|
|
|
87 (Many projects forces a given indenting style - we don't)
|
|
|
88
|
|
|
89 6. Always fill out the comment at commiting (-m switch of cvs, or
|
|
|
90 in the editor if you left -m).
|
|
|
91 It shouldn't be such lines: "fixed!" or "Changed it."
|
|
|
92 Describe in a few lines (usually 1 line is enough) what did
|
|
|
93 you changed and why did you that. You can refer mails if bugfix.
|
|
|
94
|
|
|
95 7. If you apply patch by someone else, include his name and email
|
|
|
96 in the cvs comment!
|
|
|
97
|
|
|
98 8. I've developed something called CVS-Backup. It archives CVS
|
|
|
99 repository after each commit - so I can reverse your commits
|
|
|
100 (without messing up changelog) if they are bad.
|
|
3149
|
101 If you think your bugfix or other change was bad and unneeded,
|
|
|
102 ask me to reverse it instead of commiting previous version!
|
|
2200
|
103
|
|
|
104 I think our rules aren't too hard. If you have comments, contact me.
|
