annotate stream/stream_dvd_common.h @ 27518:e54c9b7eb0d8

Revert bad changes to SSA/ASS subtitle packet format The following commits are reverted partially or completely: "a valid ASS line contains 9 ',' before actual text" "demux_mkv: output correctly formated ASS packets" "libass: add a new ass_process_data() to process demuxed subtitle packets" These commits converted the internal representation of SSA/ASS subtitle packets from the format used by Matroska to a custom format where each packet has contents exactly matching one line in complete SSA script files. AFAIK no files natively use such a format for muxed subtitles. The stated reason for this change was to use a format that could in principle be muxed into a maximal number of containers. SSA subtitles do not have an implicit duration so both start time and duration or end time need to be specified explicitly; the new format moved timing information inside the codec packet data so it could be muxed without modification into containers that can represent only start time at the container level. However such a change is wrong from the viewpoint of program architecture. Timing information belongs to the demuxer level, but these commits moved not only the duration but also the authoritative value of the start time to inside the codec data. Additionally the new format lost the value of the Matroska ReadOrder field which is used by MPlayer. This commit changes the internal packet format back to that used by Matroska and makes the internal Matroska demuxer output that format again. Libavformat still outputs the "new" format; it could be converted back to the Matroska format in demux_lavf.c, but I'm not adding that code at least yet. The current lavf code has similar problems as the reverted code in MPlayer, and it also currently fails to provide any way to access the value of the ReadOrder field. I hope that the lavf side will be improved; if it isn't conversion can be added later. For now I'll make MPlayer default to the internal Matroska demuxer instead of the lavf one in a separate commit.
author uau
date Mon, 08 Sep 2008 21:26:22 +0000
parents ea01824701a5
children 83266d299072
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
rev   line source
26029
4129c8cfa742 Add MPLAYER_ prefix to multiple inclusion guards.
diego
parents: 25553
diff changeset
1 #ifndef MPLAYER_STREAM_DVD_COMMON_H
4129c8cfa742 Add MPLAYER_ prefix to multiple inclusion guards.
diego
parents: 25553
diff changeset
2 #define MPLAYER_STREAM_DVD_COMMON_H
25553
6ac1ece1f9fe Add multiple inclusion guards to all header files that lack them.
diego
parents: 23993
diff changeset
3
27043
c333185b1c3e Add missing #includes to fix 'make checkheaders'.
diego
parents: 26906
diff changeset
4 #include "config.h"
26184
7ee4ae1648e6 Add missing header #includes to fix 'make checkheaders'.
diego
parents: 26029
diff changeset
5 #include <inttypes.h>
27341
e7c989f7a7c9 Start unifying names of internal preprocessor directives.
diego
parents: 27043
diff changeset
6 #ifdef CONFIG_DVDREAD_INTERNAL
27466
ea01824701a5 Rename internal libdvdread fork from dvdread to libdvdread
rathann
parents: 27341
diff changeset
7 #include "libdvdread/ifo_types.h"
26906
bae68d1afda2 adapted to the dvdread->libdvdread transition in dvdnav's repository
nicodvb
parents: 26184
diff changeset
8 #else
27466
ea01824701a5 Rename internal libdvdread fork from dvdread to libdvdread
rathann
parents: 27341
diff changeset
9 #include <dvdread/ifo_types.h>
26906
bae68d1afda2 adapted to the dvdread->libdvdread transition in dvdnav's repository
nicodvb
parents: 26184
diff changeset
10 #endif
26184
7ee4ae1648e6 Add missing header #includes to fix 'make checkheaders'.
diego
parents: 26029
diff changeset
11
23993
2107f38b6ca1 Moved dvdtimetomsec to stream_dvd_common.c.
cehoyos
parents:
diff changeset
12 int mp_dvdtimetomsec(dvd_time_t *dt);
25553
6ac1ece1f9fe Add multiple inclusion guards to all header files that lack them.
diego
parents: 23993
diff changeset
13
26029
4129c8cfa742 Add MPLAYER_ prefix to multiple inclusion guards.
diego
parents: 25553
diff changeset
14 #endif /* MPLAYER_STREAM_DVD_COMMON_H */