comparison libvo/vo_svga.c @ 9658:0e6d7f48309e

fix find_best fail if the black area is bigger than image, few more verbose messages, OSD not rendered if native mode

9657:4916d09a52a7

    and i don't have any of them. If it works for you then let me know. 
    I will remove this warning after confirm its status.
 -  retrace sync works only in doublebuffer mode.
 -  the retrace sync may slow down decoding a lot - mplayer is blocked while
    waiting for retrace
 -  denoice3d fails to find common colorspace, vf_scale doesn't help - I work on it.
   
TODO:
 - OSD without flicker (w/h & w/o double buffer)
 - let choose_best_mode take aspect into account
 - set palette from mpi->palette or mpi->plane[1]
 - let OSD draw in black bars - need some OSD changes
 - Make nicer CONFIG parsing
 - change video mode logical width to match img->stride[0] - for HW only 

 int bestmode,lastmode;
 int i;
 vga_modeinfo *vminfo;
//int best aspect mode // best linear mode // best normal mode (no modeX)

  prev_badness = req_w * req_h;
  bestmode = 0; //0 is the TEXT mode
  lastmode = vga_lastmodenumber();
  for(i=1;i<lastmode;i++){
    vminfo = vga_getmodeinfo(i);
    if( vminfo == NULL ) continue;

    badness=(vminfo->width * vminfo->height) - (req_h * req_w);
    //put here aspect calculations
    if(squarepix) 
      if( vminfo->width*3 != vminfo->height*4 ) continue;

    if( prev_badness >= badness ){//modeX etc...
      prev_badness=badness;
      bestmode=i;
      if(verbose>3)
        printf("vo_svga: found good mode %d with badness %d\n",i,badness);
    }

          mode_capabilities|=CAP_LINEAR;
        }
      }
    }
  }//fi force native
  
//here is the place to handle strides for accel_ modes;
  mode_stride=modeinfo->linewidth;
//we may try to set a bigger stride for video mode that will match the mpi->stride, 
//this way we will transfer more data, but HW put_image can do it in backgraund!

  x0+=x_pos;// in case of drawing over image
  y0+=y_pos;
  
  //only modes with bytesperpixel>0 can draw OSD
  if(modeinfo->bytesperpixel==0) return;
//  if(!(mode_capabilities&CAP_LINEAR)) return;//force_native will remove OSD

  base=PageStore[cpage].vbase + y0*mode_stride + x0*modeinfo->bytesperpixel;
  bytelen = modeinfo->width * modeinfo->bytesperpixel;   
  switch (mode_bpp) {
    case 32: 
      vo_draw_alpha_rgb32(w, h, src, srca, stride, base, bytelen);

9658:0e6d7f48309e

    and i don't have any of them. If it works for you then let me know. 
    I will remove this warning after confirm its status.
 -  retrace sync works only in doublebuffer mode.
 -  the retrace sync may slow down decoding a lot - mplayer is blocked while
    waiting for retrace
 -  denoise3d fails to find common colorspace, vf_scale doesn't help - It is 
    mplayer bug.
   
TODO:
 - let choose_best_mode take aspect into account
 - set palette from mpi->palette or mpi->plane[1]
 - let OSD draw in black bars - need some OSD changes
 - Make nicer CONFIG parsing
 - change video mode logical width to match img->stride[0] - for HW only 

 int bestmode,lastmode;
 int i;
 vga_modeinfo *vminfo;
//int best aspect mode // best linear mode // best normal mode (no modeX)

  prev_badness = 0;//take care of special case below
  bestmode = 0; //0 is the TEXT mode
  lastmode = vga_lastmodenumber();
  for(i=1;i<lastmode;i++){
    vminfo = vga_getmodeinfo(i);
    if( vminfo == NULL ) continue;

    badness=(vminfo->width * vminfo->height) - (req_h * req_w);
    //put here aspect calculations
    if(squarepix) 
      if( vminfo->width*3 != vminfo->height*4 ) continue;

    if( bestmode==0 || prev_badness >= badness ){//modeX etc...
      prev_badness=badness;
      bestmode=i;
      if(verbose>3)
        printf("vo_svga: found good mode %d with badness %d\n",i,badness);
    }

          mode_capabilities|=CAP_LINEAR;
        }
      }
    }
  }//fi force native
  if(mode_capabilities&CAP_LINEAR){
    printf("vo_svga: video mode is linear and memcpy could be used for image transfer\n");
  }
  if(mode_capabilities&CAP_ACCEL_PUTIMAGE){
    printf("vo_svga: video mode have hardware acceleration and put_image could be used\n");
    printf("vo_svga: If it works for you i would like to know \nvo_svga: (send log with `mplayer test.avi -v -v -v -v &> svga.log`). Thx\n");
  }
  
//here is the place to handle strides for accel_ modes;
  mode_stride=modeinfo->linewidth;
//we may try to set a bigger stride for video mode that will match the mpi->stride, 
//this way we will transfer more data, but HW put_image can do it in backgraund!

  x0+=x_pos;// in case of drawing over image
  y0+=y_pos;
  
  //only modes with bytesperpixel>0 can draw OSD
  if(modeinfo->bytesperpixel==0) return;
  if(!(mode_capabilities&CAP_LINEAR)) return;//force_native will remove OSD
  if(verbose>3)
    printf("vo_svga: OSD draw in page %d",cpage);
  base=PageStore[cpage].vbase + y0*mode_stride + x0*modeinfo->bytesperpixel;
  bytelen = modeinfo->width * modeinfo->bytesperpixel;   
  switch (mode_bpp) {
    case 32: 
      vo_draw_alpha_rgb32(w, h, src, srca, stride, base, bytelen);