Mercurial > mplayer.hg
comparison DOCS/tech/patches.txt @ 12419:3a6e4fff88e3
Hint at diff options useful for avoiding cosmetic changes, patch by Reimar.
author | diego |
---|---|
date | Tue, 04 May 2004 14:50:16 +0000 |
parents | ac3c866f159b |
children | 0d9dec871b83 |
comparison
equal
deleted
inserted
replaced
12418:80266d26d80c | 12419:3a6e4fff88e3 |
---|---|
22 3. Test the functionality of your patch. We'll *refuse* it if it breaks | 22 3. Test the functionality of your patch. We'll *refuse* it if it breaks |
23 something, even if it extends other features! | 23 something, even if it extends other features! |
24 | 24 |
25 4. Read your patch. We'll *refuse* it if it changes indentation of the | 25 4. Read your patch. We'll *refuse* it if it changes indentation of the |
26 code or if it does tab/space conversion or other cosmetical changes! | 26 code or if it does tab/space conversion or other cosmetical changes! |
27 | |
28 NOTE: If you alread wrote some code and did cosmetic changes, you can use | |
29 'diff -uwbBE' to help you remove them. Don't forget to check the patch | |
30 to make sure diff didn't ignore some important change and remove any | |
31 remaining cosmetics! | |
27 | 32 |
28 5. Comment parts that really need it (tricky side-effects etc). | 33 5. Comment parts that really need it (tricky side-effects etc). |
29 Commenting trivial code not required. Comments must be English! | 34 Commenting trivial code not required. Comments must be English! |
30 | 35 |
31 6. If you implement new features, add or change command line switches or modify | 36 6. If you implement new features, add or change command line switches or modify |