Mercurial > mplayer.hg
comparison DOCS/tech/patches.txt @ 7645:534b9b6f6557
Some further explanations, dev-eng is now subscribers only.
author | diego |
---|---|
date | Mon, 07 Oct 2002 00:46:57 +0000 |
parents | 56cef6e35f51 |
children | 7b6b7fb76965 |
comparison
equal
deleted
inserted
replaced
7644:b757512b906e | 7645:534b9b6f6557 |
---|---|
1 Sending patches: | 1 Sending patches: |
2 ~~~~~~~~~~~~~~~~ | 2 ~~~~~~~~~~~~~~~~ |
3 Note: We know these rules are hard, but it's hard to maintain such a | |
4 big and complex project, so you should accept our rules. We have no | |
5 time for fixing buggy, broken or old patches! | |
6 | 3 |
7 1. Always make patches for the CVS version. | 4 Note: We know our rules place a burden on you, but rest assured that |
8 We do not accept patches for old versions or releases. | 5 maintaining a big and complex software project is even harder, so please |
6 accept our rules. We cannot afford to spend our time fixing buggy, broken or | |
7 outdated patches. | |
8 | |
9 1. Always make patches for the CVS version. The README describes how to check | |
10 out CVS and daily CVS snapshots are available from our download page. | |
11 We do not accept patches for releases or outdated CVS versions. | |
9 | 12 |
10 2. Make unified diffs ('diff -Naur' or 'cvs diff -u'). | 13 2. Make unified diffs ('diff -Naur' or 'cvs diff -u'). |
11 | 14 |
12 3. Test the functionality of your patch. We'll *refuse* it if it breaks | 15 3. Test the functionality of your patch. We'll *refuse* it if it breaks |
13 something, even if it extends other features! | 16 something, even if it extends other features! |
16 code or if it does tab/space conversion or other cosmetical changes! | 19 code or if it does tab/space conversion or other cosmetical changes! |
17 | 20 |
18 5. Comment parts that really need it (tricky side-effects etc). | 21 5. Comment parts that really need it (tricky side-effects etc). |
19 Commenting trivial code not required. Comments must be English! | 22 Commenting trivial code not required. Comments must be English! |
20 | 23 |
21 6. Do not ask for CVS write access at first time. If you contributed | 24 6. Send your patch to the mplayer-dev-eng mailing list as a base64-encoded |
22 1 or more nice, acceptable patches and they need maintaining or | 25 attachment (use gzip or bzip2 *only* if it's bigger than 80k or if you know |
23 you want to be an mplayer developer, you'll get CVS write access. | 26 that your mailer messes up (reformats) text attachments) with the subject |
24 | 27 line: '[PATCH] very short description of the patch'. |
25 7. Subscribe to the mplayer-dev-eng list (don't worry, it's low traffic) | |
26 and send your patch there as base64-encoded attachment (use gzip or | |
27 bzip2 *only* if it's really big or if you know that your mailer messes | |
28 up (reformats) text attachments). | |
29 Subject line should be: '[PATCH] very short description of the patch'. | |
30 In the mail, describe in a few sentences what you change and why. | 28 In the mail, describe in a few sentences what you change and why. |
31 If you made independent changes, try to send them as separate patches. | 29 If you made independent changes, try to send them as separate patches. |
32 The subject line is very important if you do not want your patch to get | 30 The subject line is very important if you do not want your patch to get |
33 lost in the noise. We need the uppercase [PATCH] to be able to search | 31 lost in the noise. We need the uppercase [PATCH] to be able to search |
34 for unapplied patches, so please use it. | 32 for unapplied patches, so please use it. |
33 You have to subscribe to mplayer-dev-eng since we blocked postings from | |
34 non-subscribers after spam problems and because patches get reviewed by the | |
35 developers on the list. We want you to be available for discussing your | |
36 code, you might be asked to make modifications before we accept it. Don't | |
37 worry, mplayer-dev-eng is not high traffic and you can subscribe with the | |
38 nomail option if you do not wish to receive all the mails. | |
35 | 39 |
40 7. Do not immediately ask for CVS write access. If you contributed one or more | |
41 nice, acceptable patches and they need maintaining or you want to be an | |
42 MPlayer developer, you'll get CVS write access. | |
43 | |
36 Thank you! | 44 Thank you! |
37 | |
38 A'rpi |