comparison DOCS/tech/patches.txt @ 18372:71748783e001

Expand a bit, clarification and grammar fix.

18371:50b3c9a53e21

    out CVS and daily CVS snapshots are available from our download page.
    We do not accept patches for releases or outdated CVS versions.

 2. Make unified diffs ('diff -Naur' or 'cvs diff -u'). Unified diffs can be
    applied easily with 'patch'. This is much harder with other diff types.

 3. Create the diff from the root of the MPlayer source tree, this makes the
    diff easier to apply as it saves the step of changing to the correct
    directory.

 4. Test the functionality of your patch. We'll *refuse* it if it breaks
    something, even if it extends other features!

 5. Read your patch. We'll *refuse* it if it changes indentation of the

    strings, remove the occurrences of these strings from the translations.
    There may be (compilation) trouble if outdated translations remain in place
    and translators will pick up changes more easily if they see a new message
    that has to be translated.

15. If you send a modified or updated version of you patch, always resend
    the complete patch. It is very time consuming and error prone to piece 
    patches together that are distributed over several mails.
    Please always resend patches as replies to the original mail to keep
    the thread with the discussion together.

Thank you!

18372:71748783e001

    out CVS and daily CVS snapshots are available from our download page.
    We do not accept patches for releases or outdated CVS versions.

 2. Make unified diffs ('diff -Naur' or 'cvs diff -u'). Unified diffs can be
    applied easily with 'patch'. This is much harder with other diff types.
    Besides, unified diffs are more readable and thus easier to review.

 3. Create the diff from the root of the MPlayer source tree, this makes the
    diff easier to apply as it saves the step of searching for and changing
    to the correct directory.

 4. Test the functionality of your patch. We'll *refuse* it if it breaks
    something, even if it extends other features!

 5. Read your patch. We'll *refuse* it if it changes indentation of the

    strings, remove the occurrences of these strings from the translations.
    There may be (compilation) trouble if outdated translations remain in place
    and translators will pick up changes more easily if they see a new message
    that has to be translated.

15. If you send a modified or updated version of your patch, resend the
    complete patch. It is very time-consuming and error-prone to piece
    together patches that are distributed over several mails.
    Please always resend patches as replies to the original mail to keep
    the thread with the discussion together.

Thank you!