Mercurial > mplayer.hg
comparison DOCS/tech/patches.txt @ 18372:71748783e001
Expand a bit, clarification and grammar fix.
author | diego |
---|---|
date | Mon, 01 May 2006 14:46:49 +0000 |
parents | e20114911d05 |
children | 80df1b8c3759 |
comparison
equal
deleted
inserted
replaced
18371:50b3c9a53e21 | 18372:71748783e001 |
---|---|
16 out CVS and daily CVS snapshots are available from our download page. | 16 out CVS and daily CVS snapshots are available from our download page. |
17 We do not accept patches for releases or outdated CVS versions. | 17 We do not accept patches for releases or outdated CVS versions. |
18 | 18 |
19 2. Make unified diffs ('diff -Naur' or 'cvs diff -u'). Unified diffs can be | 19 2. Make unified diffs ('diff -Naur' or 'cvs diff -u'). Unified diffs can be |
20 applied easily with 'patch'. This is much harder with other diff types. | 20 applied easily with 'patch'. This is much harder with other diff types. |
21 Besides, unified diffs are more readable and thus easier to review. | |
21 | 22 |
22 3. Create the diff from the root of the MPlayer source tree, this makes the | 23 3. Create the diff from the root of the MPlayer source tree, this makes the |
23 diff easier to apply as it saves the step of changing to the correct | 24 diff easier to apply as it saves the step of searching for and changing |
24 directory. | 25 to the correct directory. |
25 | 26 |
26 4. Test the functionality of your patch. We'll *refuse* it if it breaks | 27 4. Test the functionality of your patch. We'll *refuse* it if it breaks |
27 something, even if it extends other features! | 28 something, even if it extends other features! |
28 | 29 |
29 5. Read your patch. We'll *refuse* it if it changes indentation of the | 30 5. Read your patch. We'll *refuse* it if it changes indentation of the |
105 strings, remove the occurrences of these strings from the translations. | 106 strings, remove the occurrences of these strings from the translations. |
106 There may be (compilation) trouble if outdated translations remain in place | 107 There may be (compilation) trouble if outdated translations remain in place |
107 and translators will pick up changes more easily if they see a new message | 108 and translators will pick up changes more easily if they see a new message |
108 that has to be translated. | 109 that has to be translated. |
109 | 110 |
110 15. If you send a modified or updated version of you patch, always resend | 111 15. If you send a modified or updated version of your patch, resend the |
111 the complete patch. It is very time consuming and error prone to piece | 112 complete patch. It is very time-consuming and error-prone to piece |
112 patches together that are distributed over several mails. | 113 together patches that are distributed over several mails. |
113 Please always resend patches as replies to the original mail to keep | 114 Please always resend patches as replies to the original mail to keep |
114 the thread with the discussion together. | 115 the thread with the discussion together. |
115 | 116 |
116 Thank you! | 117 Thank you! |