Mercurial > mplayer.hg

comparison DOCS/tech/patches.txt @ 13258:7903766338f7

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
some new patch policy: compression, mail threading, printf vs mp_msg
author diego
date Mon, 06 Sep 2004 09:05:38 +0000
parents ccce2d564161
children ea01d0554a6e
comparison
equal deleted inserted replaced
13257:9e8b984a39a5 13258:7903766338f7
58 lost in the noise. We need the uppercase [PATCH] to be able to search 58 lost in the noise. We need the uppercase [PATCH] to be able to search
59 for unapplied patches, so please use it. 59 for unapplied patches, so please use it.
60 Do not compress your patch unless it is larger than 80k or if you know 60 Do not compress your patch unless it is larger than 80k or if you know
61 that your mailer messes up (reformats) text attachments. It only makes 61 that your mailer messes up (reformats) text attachments. It only makes
62 handling the patch more difficult. If you have to compress your patch, 62 handling the patch more difficult. If you have to compress your patch,
63 use bzip2 or gzip to compress it, not another non-standard format. 63 use either bzip2, gzip or zip to compress it, not a different format.
64 You have to subscribe to mplayer-dev-eng since we blocked postings from 64 You have to subscribe to mplayer-dev-eng since we blocked postings from
65 non-subscribers after spam problems and because patches get reviewed by 65 non-subscribers after spam problems and because patches get reviewed by
66 the developers on the list. We want you to be available for discussing 66 the developers on the list. We want you to be available for discussing
67 your code, you might be asked to make modifications before we accept it. 67 your code, you might be asked to make modifications before we accept it.
68 Don't worry, mplayer-dev-eng is not high traffic and you can subscribe 68 Don't worry, mplayer-dev-eng is not high traffic and you can subscribe
69 but unset the "Mail delivery" option so that you can post without getting 69 but unset the "Mail delivery" option so that you can post without getting
70 any mails. 70 any mails.
71 Try to avoid uploading the patch to a web or FTP site, send it directly 71 Do not upload the patch to a web or FTP site, send it directly to the
72 to the mailing list. The fewer steps it takes us to get at the patch the 72 mailing list. The fewer steps it takes us to get at the patch the higher
73 higher the likelihood for it to get reviewed and applied. If your patch 73 the likelihood for it to get reviewed and applied. If your patch is so
74 is so big you cannot send it by mail, try splitting it into pieces. 74 big you cannot send it by mail, try splitting it into smaller pieces.
75 75
76 9. Give us a few days to react. We try to review patches as fast as possible, 76 9. Give us a few days to react. We try to review patches as fast as possible,
77 but unfortunately we are constantly overloaded with work, be it MPlayer- 77 but unfortunately we are constantly overloaded with work, be it MPlayer-
78 related or from our day to day lives. If your patch seems to be ignored, 78 related or from our day to day lives. If your patch seems to be ignored,
79 please resend it and mention that you got ignored. We are interested in 79 send a reminder asking for opinions as a reply to the original patch and
80 your work and will eventually either accept it or reject it with an 80 mention that you got ignored. We are interested in your work and will
81 explanation of what we disliked about your patch. 81 eventually either accept it or reject it with an explanation of what we
82 disliked about your patch. We will often ask you to make changes to your
83 patch to make it acceptable. Implement them if you want to see your patch
84 applied and send the update to the mailing list. Remember that updates and
85 reminders must be sent as replies to the original patch to preserve proper
86 mail threading.
82 87
83 10. Do not immediately ask for CVS write access. If you have contributed one or 88 10. Do not immediately ask for CVS write access. If you have contributed one or
84 more nice, acceptable patches and they need maintaining or you want to 89 more nice, acceptable patches and they need maintaining or you want to
85 be an MPlayer developer, you'll get CVS write access. 90 be an MPlayer developer, you'll get CVS write access.
86 91
87 11. For consistency reasons, all option names must use '-' instead of '_'. 92 11. For consistency reasons, all option names must use '-' instead of '_'.
88 93
89 12. If you make a nontrivial contribution and wish to be mentioned in the 94 12. If you make a nontrivial contribution and wish to be mentioned in the
90 AUTHORS file, include that in your patch. 95 AUTHORS file, include that in your patch.
91 96
97 13. Do not use printf for console output, use our own mp_msg functions instead.
98 For the output to be translated (which includes all messages of level
99 MSGL_HINT and below), put the strings in help/help_mp-en.h. If you change
100 strings, remove the occurrences of these strings from the translations.
101 There may be (compilation) trouble if outdated translations remain in place
102 and translators will pick up changes more easily if they see a new message
103 that has to be translated.
104
92 Thank you! 105 Thank you!