Mercurial > mplayer.hg
comparison DOCS/tech/patches.txt @ 2121:95b8a1e7962d
sending patches
| author | arpi |
|---|---|
| date | Sun, 07 Oct 2001 16:34:47 +0000 |
| parents | |
| children | 408302343afe |
comparison
equal
deleted
inserted
replaced
| 2120:83df55c88850 | 2121:95b8a1e7962d |
|---|---|
| 1 Sending patches: | |
| 2 ~~~~~~~~~~~~~~~~ | |
| 3 Note: We know these rules are hard, but it's hard to maintain such | |
| 4 big and complex project, so you should accept our rules. We have no | |
| 5 time for fixing buggy, broken or old patches! | |
| 6 | |
| 7 1. Always make patch for the CVS version. | |
| 8 We do not accept patches for old versions or releases. | |
| 9 | |
| 10 2. Make unified diffs ('diff -Naur' or 'cvs diff -u') | |
| 11 | |
| 12 3. Test functionality of your patch. We'll *refuse* it if it breaks | |
| 13 something, even if it extends other features! | |
| 14 | |
| 15 4. Read your patch. We'll *refuse* it if it changes indent of the | |
| 16 code or it does tab/space or other cosmetical changes! | |
| 17 | |
| 18 5. Comment parts what really needs it (has tricky side-effects etc). | |
| 19 Commenting trivial code not requires. Comments must be english! | |
| 20 | |
| 21 6. Do not ask for CVS write access at first time. If you contributed | |
| 22 1 or more nice, acceptable patches and they need maintaining or | |
| 23 you want to be mplayer developer, you'll get CVS write access. | |
| 24 | |
| 25 7. Subscribe to the mplayer-dev-eng list (don't worry, it's low traffic) | |
| 26 and send your patch there as base64-encoded attachment (use gzip or | |
| 27 bzip2 *only* if it's really big). Also describe in a few sentences | |
| 28 what (and why) are the changes. | |
| 29 | |
| 30 Thank you! | |
| 31 | |
| 32 A'rpi |