Mercurial > mplayer.hg
comparison DOCS/tech/new_policy_proposal.txt @ 22591:e27b971ccae5
update spliting rule to what i just added to ffmpeg
comments welcome
author | michael |
---|---|
date | Thu, 15 Mar 2007 12:45:04 +0000 |
parents | e03a45f3a360 |
children | c3501315b4d0 |
comparison
equal
deleted
inserted
replaced
22590:e03a45f3a360 | 22591:e27b971ccae5 |
---|---|
103 (portability, exploits compiler bugs, unusual environment etc) they will be | 103 (portability, exploits compiler bugs, unusual environment etc) they will be |
104 reported and eventually fixed. | 104 reported and eventually fixed. |
105 | 105 |
106 Splitting changes | 106 Splitting changes |
107 Do not commit unrelated changes together, split them into self-contained | 107 Do not commit unrelated changes together, split them into self-contained |
108 pieces. | 108 pieces. Also dont forget that if part B depends on part A but A doesnt |
109 if you have any doubt discuss it on the developer mailing list before | 109 depend on B, then A can and should be commited first and seperately from B. |
110 committing, also when in doubt more splitting is better then less, changes | 110 Keeping changes well split into self contained parts makes reviewing and |
111 which are larger then 10kbyte generally should be split into several | 111 understanding them on svn log at the time of commit and later when |
112 incremental changes if possible even if you think they are all related | 112 debugging a bug much easier. |
113 keeping changes well split makes reviewing and understanding them on | 113 Also if you have doubt about spliting or not spliting, dont hesitate to |
114 svn log at the time of commit and later when debugging a bug much easier | 114 ask/disscuss it on the developer mailing list. |
115 | 115 |
116 4. Do not change behavior of the program (renaming options etc) or | 116 4. Do not change behavior of the program (renaming options etc) or |
117 remove functionality from the code without approval in a discussion on | 117 remove functionality from the code without approval in a discussion on |
118 the mplayer-dev-eng mailing list. | 118 the mplayer-dev-eng mailing list. |
119 | 119 |