comparison cpudetect.c @ 17566:f580a7755ac5

Patch by Stefan Huehner / stefan % huehner ! org \ patch replaces '()' for the correct '(void)' in function declarations/prototypes which have no parameters. The '()' syntax tell thats there is a variable list of arguments, so that the compiler cannot check this. The extra CFLAG '-Wstrict-declarations' shows those cases. Comments about a similar patch applied to ffmpeg: That in C++ these mean the same, but in ANSI C the semantics are different; function() is an (obsolete) K&R C style forward declaration, it basically means that the function can have any number and any types of parameters, effectively completely preventing the compiler from doing any sort of type checking. -- Erik Slagter Defining functions with unspecified arguments is allowed but bad. With arguments unspecified the compiler can't report an error/warning if the function is called with incorrect arguments. -- M\ns Rullg\rd
author rathann
date Thu, 09 Feb 2006 14:08:03 +0000
parents fab832f37083
children 485f04e5a58c
comparison
equal deleted inserted replaced
17565:dc65faaadb04 17566:f580a7755ac5
43 43
44 static void check_os_katmai_support( void ); 44 static void check_os_katmai_support( void );
45 45
46 #if 1 46 #if 1
47 // return TRUE if cpuid supported 47 // return TRUE if cpuid supported
48 static int has_cpuid() 48 static int has_cpuid(void)
49 { 49 {
50 long a, c; 50 long a, c;
51 51
52 // code from libavcodec: 52 // code from libavcodec:
53 __asm__ __volatile__ ( 53 __asm__ __volatile__ (