Mercurial > mplayer.hg
comparison libmpcodecs/vf_scale.c @ 17566:f580a7755ac5
Patch by Stefan Huehner / stefan % huehner ! org \
patch replaces '()' for the correct '(void)' in function
declarations/prototypes which have no parameters. The '()' syntax tell
thats there is a variable list of arguments, so that the compiler cannot
check this. The extra CFLAG '-Wstrict-declarations' shows those cases.
Comments about a similar patch applied to ffmpeg:
That in C++ these mean the same, but in ANSI C the semantics are
different; function() is an (obsolete) K&R C style forward declaration,
it basically means that the function can have any number and any types
of parameters, effectively completely preventing the compiler from doing
any sort of type checking. -- Erik Slagter
Defining functions with unspecified arguments is allowed but bad.
With arguments unspecified the compiler can't report an error/warning
if the function is called with incorrect arguments. -- M\ns Rullg\rd
author | rathann |
---|---|
date | Thu, 09 Feb 2006 14:08:03 +0000 |
parents | 73ed22ef2035 |
children | 168d8eb397f1 |
comparison
equal
deleted
inserted
replaced
17565:dc65faaadb04 | 17566:f580a7755ac5 |
---|---|
490 int sws_chr_vshift= 0; | 490 int sws_chr_vshift= 0; |
491 int sws_chr_hshift= 0; | 491 int sws_chr_hshift= 0; |
492 float sws_chr_sharpen= 0.0; | 492 float sws_chr_sharpen= 0.0; |
493 float sws_lum_sharpen= 0.0; | 493 float sws_lum_sharpen= 0.0; |
494 | 494 |
495 int get_sws_cpuflags(){ | 495 int get_sws_cpuflags(void){ |
496 return | 496 return |
497 (gCpuCaps.hasMMX ? SWS_CPU_CAPS_MMX : 0) | 497 (gCpuCaps.hasMMX ? SWS_CPU_CAPS_MMX : 0) |
498 | (gCpuCaps.hasMMX2 ? SWS_CPU_CAPS_MMX2 : 0) | 498 | (gCpuCaps.hasMMX2 ? SWS_CPU_CAPS_MMX2 : 0) |
499 | (gCpuCaps.has3DNow ? SWS_CPU_CAPS_3DNOW : 0) | 499 | (gCpuCaps.has3DNow ? SWS_CPU_CAPS_3DNOW : 0) |
500 | (gCpuCaps.hasAltiVec ? SWS_CPU_CAPS_ALTIVEC : 0); | 500 | (gCpuCaps.hasAltiVec ? SWS_CPU_CAPS_ALTIVEC : 0); |