Mercurial > mplayer.hg
comparison libvo/gl_common.c @ 17566:f580a7755ac5
Patch by Stefan Huehner / stefan % huehner ! org \
patch replaces '()' for the correct '(void)' in function
declarations/prototypes which have no parameters. The '()' syntax tell
thats there is a variable list of arguments, so that the compiler cannot
check this. The extra CFLAG '-Wstrict-declarations' shows those cases.
Comments about a similar patch applied to ffmpeg:
That in C++ these mean the same, but in ANSI C the semantics are
different; function() is an (obsolete) K&R C style forward declaration,
it basically means that the function can have any number and any types
of parameters, effectively completely preventing the compiler from doing
any sort of type checking. -- Erik Slagter
Defining functions with unspecified arguments is allowed but bad.
With arguments unspecified the compiler can't report an error/warning
if the function is called with incorrect arguments. -- M\ns Rullg\rd
author | rathann |
---|---|
date | Thu, 09 Feb 2006 14:08:03 +0000 |
parents | 433e35de3b10 |
children | 01ca8a5fb8a6 |
comparison
equal
deleted
inserted
replaced
17565:dc65faaadb04 | 17566:f580a7755ac5 |
---|---|
1142 glXDestroyContext(mDisplay, *context); | 1142 glXDestroyContext(mDisplay, *context); |
1143 } | 1143 } |
1144 *context = 0; | 1144 *context = 0; |
1145 } | 1145 } |
1146 | 1146 |
1147 void swapGlBuffers() { | 1147 void swapGlBuffers(void) { |
1148 glXSwapBuffers(mDisplay, vo_window); | 1148 glXSwapBuffers(mDisplay, vo_window); |
1149 } | 1149 } |
1150 #endif | 1150 #endif |
1151 | 1151 |