Mercurial > mplayer.hg
comparison libvo/gl_common.h @ 17566:f580a7755ac5
Patch by Stefan Huehner / stefan % huehner ! org \
patch replaces '()' for the correct '(void)' in function
declarations/prototypes which have no parameters. The '()' syntax tell
thats there is a variable list of arguments, so that the compiler cannot
check this. The extra CFLAG '-Wstrict-declarations' shows those cases.
Comments about a similar patch applied to ffmpeg:
That in C++ these mean the same, but in ANSI C the semantics are
different; function() is an (obsolete) K&R C style forward declaration,
it basically means that the function can have any number and any types
of parameters, effectively completely preventing the compiler from doing
any sort of type checking. -- Erik Slagter
Defining functions with unspecified arguments is allowed but bad.
With arguments unspecified the compiler can't report an error/warning
if the function is called with incorrect arguments. -- M\ns Rullg\rd
author | rathann |
---|---|
date | Thu, 09 Feb 2006 14:08:03 +0000 |
parents | a27e52b838e3 |
children | b822575a1140 |
comparison
equal
deleted
inserted
replaced
17565:dc65faaadb04 | 17566:f580a7755ac5 |
---|---|
243 #define vo_ontop() vo_x11_ontop() | 243 #define vo_ontop() vo_x11_ontop() |
244 #define vo_uninit() vo_x11_uninit() | 244 #define vo_uninit() vo_x11_uninit() |
245 int setGlWindow(XVisualInfo **vinfo, GLXContext *context, Window win); | 245 int setGlWindow(XVisualInfo **vinfo, GLXContext *context, Window win); |
246 void releaseGlContext(XVisualInfo **vinfo, GLXContext *context); | 246 void releaseGlContext(XVisualInfo **vinfo, GLXContext *context); |
247 #endif | 247 #endif |
248 void swapGlBuffers(); | 248 void swapGlBuffers(void); |
249 | 249 |
250 extern void (APIENTRY *GenBuffers)(GLsizei, GLuint *); | 250 extern void (APIENTRY *GenBuffers)(GLsizei, GLuint *); |
251 extern void (APIENTRY *DeleteBuffers)(GLsizei, const GLuint *); | 251 extern void (APIENTRY *DeleteBuffers)(GLsizei, const GLuint *); |
252 extern void (APIENTRY *BindBuffer)(GLenum, GLuint); | 252 extern void (APIENTRY *BindBuffer)(GLenum, GLuint); |
253 extern GLvoid* (APIENTRY *MapBuffer)(GLenum, GLenum); | 253 extern GLvoid* (APIENTRY *MapBuffer)(GLenum, GLenum); |