comparison libvo/sub.c @ 17566:f580a7755ac5

Patch by Stefan Huehner / stefan % huehner ! org \ patch replaces '()' for the correct '(void)' in function declarations/prototypes which have no parameters. The '()' syntax tell thats there is a variable list of arguments, so that the compiler cannot check this. The extra CFLAG '-Wstrict-declarations' shows those cases. Comments about a similar patch applied to ffmpeg: That in C++ these mean the same, but in ANSI C the semantics are different; function() is an (obsolete) K&R C style forward declaration, it basically means that the function can have any number and any types of parameters, effectively completely preventing the compiler from doing any sort of type checking. -- Erik Slagter Defining functions with unspecified arguments is allowed but bad. With arguments unspecified the compiler can't report an error/warning if the function is called with incorrect arguments. -- M\ns Rullg\rd
author rathann
date Thu, 09 Feb 2006 14:08:03 +0000
parents a6a03ff1ddef
children e75ab7767078
comparison
equal deleted inserted replaced
17565:dc65faaadb04 17566:f580a7755ac5
729 void *vo_spudec=NULL; 729 void *vo_spudec=NULL;
730 void *vo_vobsub=NULL; 730 void *vo_vobsub=NULL;
731 731
732 static int draw_alpha_init_flag=0; 732 static int draw_alpha_init_flag=0;
733 733
734 extern void vo_draw_alpha_init(); 734 extern void vo_draw_alpha_init(void);
735 735
736 mp_osd_obj_t* vo_osd_list=NULL; 736 mp_osd_obj_t* vo_osd_list=NULL;
737 737
738 mp_osd_obj_t* new_osd_obj(int type){ 738 mp_osd_obj_t* new_osd_obj(int type){
739 mp_osd_obj_t* osd=malloc(sizeof(mp_osd_obj_t)); 739 mp_osd_obj_t* osd=malloc(sizeof(mp_osd_obj_t));
745 osd->bitmap_buffer = NULL; 745 osd->bitmap_buffer = NULL;
746 osd->allocated = -1; 746 osd->allocated = -1;
747 return osd; 747 return osd;
748 } 748 }
749 749
750 void free_osd_list(){ 750 void free_osd_list(void){
751 mp_osd_obj_t* obj=vo_osd_list; 751 mp_osd_obj_t* obj=vo_osd_list;
752 while(obj){ 752 while(obj){
753 mp_osd_obj_t* next=obj->next; 753 mp_osd_obj_t* next=obj->next;
754 if (obj->alpha_buffer) free(obj->alpha_buffer); 754 if (obj->alpha_buffer) free(obj->alpha_buffer);
755 if (obj->bitmap_buffer) free(obj->bitmap_buffer); 755 if (obj->bitmap_buffer) free(obj->bitmap_buffer);
855 obj=obj->next; 855 obj=obj->next;
856 } 856 }
857 return chg; 857 return chg;
858 } 858 }
859 859
860 void vo_init_osd(){ 860 void vo_init_osd(void){
861 if(!draw_alpha_init_flag){ 861 if(!draw_alpha_init_flag){
862 draw_alpha_init_flag=1; 862 draw_alpha_init_flag=1;
863 vo_draw_alpha_init(); 863 vo_draw_alpha_init();
864 } 864 }
865 if(vo_osd_list) free_osd_list(); 865 if(vo_osd_list) free_osd_list();