Mercurial > mplayer.hg
comparison libvo/vo_x11.c @ 17566:f580a7755ac5
Patch by Stefan Huehner / stefan % huehner ! org \
patch replaces '()' for the correct '(void)' in function
declarations/prototypes which have no parameters. The '()' syntax tell
thats there is a variable list of arguments, so that the compiler cannot
check this. The extra CFLAG '-Wstrict-declarations' shows those cases.
Comments about a similar patch applied to ffmpeg:
That in C++ these mean the same, but in ANSI C the semantics are
different; function() is an (obsolete) K&R C style forward declaration,
it basically means that the function can have any number and any types
of parameters, effectively completely preventing the compiler from doing
any sort of type checking. -- Erik Slagter
Defining functions with unspecified arguments is allowed but bad.
With arguments unspecified the compiler can't report an error/warning
if the function is called with incorrect arguments. -- M\ns Rullg\rd
author | rathann |
---|---|
date | Thu, 09 Feb 2006 14:08:03 +0000 |
parents | fd51fd1ff231 |
children | 6eb3a513abb9 |
comparison
equal
deleted
inserted
replaced
17565:dc65faaadb04 | 17566:f580a7755ac5 |
---|---|
146 static SwsContext *swsContext = NULL; | 146 static SwsContext *swsContext = NULL; |
147 extern int sws_flags; | 147 extern int sws_flags; |
148 | 148 |
149 static XVisualInfo vinfo; | 149 static XVisualInfo vinfo; |
150 | 150 |
151 static void getMyXImage() | 151 static void getMyXImage(void) |
152 { | 152 { |
153 #ifdef HAVE_SHM | 153 #ifdef HAVE_SHM |
154 if (mLocalDisplay && XShmQueryExtension(mDisplay)) | 154 if (mLocalDisplay && XShmQueryExtension(mDisplay)) |
155 Shmem_Flag = 1; | 155 Shmem_Flag = 1; |
156 else | 156 else |
236 #ifdef HAVE_SHM | 236 #ifdef HAVE_SHM |
237 } | 237 } |
238 #endif | 238 #endif |
239 } | 239 } |
240 | 240 |
241 static void freeMyXImage() | 241 static void freeMyXImage(void) |
242 { | 242 { |
243 #ifdef HAVE_SHM | 243 #ifdef HAVE_SHM |
244 if (Shmem_Flag) | 244 if (Shmem_Flag) |
245 { | 245 { |
246 XShmDetach(mDisplay, &Shminfo[0]); | 246 XShmDetach(mDisplay, &Shminfo[0]); |