Mercurial > mplayer.hg
comparison mp_msg.c @ 17566:f580a7755ac5
Patch by Stefan Huehner / stefan % huehner ! org \
patch replaces '()' for the correct '(void)' in function
declarations/prototypes which have no parameters. The '()' syntax tell
thats there is a variable list of arguments, so that the compiler cannot
check this. The extra CFLAG '-Wstrict-declarations' shows those cases.
Comments about a similar patch applied to ffmpeg:
That in C++ these mean the same, but in ANSI C the semantics are
different; function() is an (obsolete) K&R C style forward declaration,
it basically means that the function can have any number and any types
of parameters, effectively completely preventing the compiler from doing
any sort of type checking. -- Erik Slagter
Defining functions with unspecified arguments is allowed but bad.
With arguments unspecified the compiler can't report an error/warning
if the function is called with incorrect arguments. -- M\ns Rullg\rd
author | rathann |
---|---|
date | Thu, 09 Feb 2006 14:08:03 +0000 |
parents | de9a36b1082c |
children | b238eeec6ae6 |
comparison
equal
deleted
inserted
replaced
17565:dc65faaadb04 | 17566:f580a7755ac5 |
---|---|
22 | 22 |
23 int mp_msg_levels[MSGT_MAX]; // verbose level of this module. inited to 2 | 23 int mp_msg_levels[MSGT_MAX]; // verbose level of this module. inited to 2 |
24 int mp_msg_level_all = MSGL_STATUS; | 24 int mp_msg_level_all = MSGL_STATUS; |
25 int verbose = 0; | 25 int verbose = 0; |
26 | 26 |
27 void mp_msg_init(){ | 27 void mp_msg_init(void){ |
28 int i; | 28 int i; |
29 char *env = getenv("MPLAYER_VERBOSE"); | 29 char *env = getenv("MPLAYER_VERBOSE"); |
30 if (env) | 30 if (env) |
31 verbose = atoi(env); | 31 verbose = atoi(env); |
32 #ifdef USE_I18N | 32 #ifdef USE_I18N |