diff divx4_vbr.h @ 17566:f580a7755ac5

Patch by Stefan Huehner / stefan % huehner ! org \ patch replaces '()' for the correct '(void)' in function declarations/prototypes which have no parameters. The '()' syntax tell thats there is a variable list of arguments, so that the compiler cannot check this. The extra CFLAG '-Wstrict-declarations' shows those cases. Comments about a similar patch applied to ffmpeg: That in C++ these mean the same, but in ANSI C the semantics are different; function() is an (obsolete) K&R C style forward declaration, it basically means that the function can have any number and any types of parameters, effectively completely preventing the compiler from doing any sort of type checking. -- Erik Slagter Defining functions with unspecified arguments is allowed but bad. With arguments unspecified the compiler can't report an error/warning if the function is called with incorrect arguments. -- M���\ns Rullg���\rd

--- a/divx4_vbr.h	Thu Feb 09 10:23:51 2006 +0000
+++ b/divx4_vbr.h	Thu Feb 09 14:08:03 2006 +0000
@@ -5,13 +5,13 @@
 	int VbrControl_init_2pass_vbr_encoding(const char* filename, int bitrate, double framerate, int crispness, int quality);
 	int VbrControl_init_2pass_vbr_analysis(const char* filename, int quality);
 
-	void VbrControl_update_1pass_vbr();
+	void VbrControl_update_1pass_vbr(void);
 	void VbrControl_update_2pass_vbr_encoding(int motion_bits, int texture_bits, int total_bits);
 	void VbrControl_update_2pass_vbr_analysis(int is_key_frame, int motion_bits, int texture_bits, int total_bits, int quant);
 
-	int VbrControl_get_quant();
+	int VbrControl_get_quant(void);
 	void VbrControl_set_quant(float q);
-	int VbrControl_get_intra();
-	short VbrControl_get_drop();
-	void VbrControl_close();
+	int VbrControl_get_intra(void);
+	short VbrControl_get_drop(void);
+	void VbrControl_close(void);