Mercurial > mplayer.hg
diff libao2/ao_mpegpes.c @ 17566:f580a7755ac5
Patch by Stefan Huehner / stefan % huehner ! org \
patch replaces '()' for the correct '(void)' in function
declarations/prototypes which have no parameters. The '()' syntax tell
thats there is a variable list of arguments, so that the compiler cannot
check this. The extra CFLAG '-Wstrict-declarations' shows those cases.
Comments about a similar patch applied to ffmpeg:
That in C++ these mean the same, but in ANSI C the semantics are
different; function() is an (obsolete) K&R C style forward declaration,
it basically means that the function can have any number and any types
of parameters, effectively completely preventing the compiler from doing
any sort of type checking. -- Erik Slagter
Defining functions with unspecified arguments is allowed but bad.
With arguments unspecified the compiler can't report an error/warning
if the function is called with incorrect arguments. -- M\ns Rullg\rd
author | rathann |
---|---|
date | Thu, 09 Feb 2006 14:08:03 +0000 |
parents | 815f03b7cee5 |
children | 3f2de7ba8aa0 |
line wrap: on
line diff
--- a/libao2/ao_mpegpes.c Thu Feb 09 10:23:51 2006 +0000 +++ b/libao2/ao_mpegpes.c Thu Feb 09 14:08:03 2006 +0000 @@ -137,19 +137,19 @@ } // stop playing and empty buffers (for seeking/pause) -static void reset(){ +static void reset(void){ } // stop playing, keep buffers (for pause) -static void audio_pause() +static void audio_pause(void) { // for now, just call reset(); reset(); } // resume playing, after audio_pause() -static void audio_resume() +static void audio_resume(void) { } @@ -158,7 +158,7 @@ extern int vo_pts; // return: how many bytes can be played without blocking -static int get_space(){ +static int get_space(void){ float x=(float)(vo_pts-ao_data.pts)/90000.0; int y; // printf("vo_pts: %5.3f ao_pts: %5.3f\n",vo_pts/90000.0,ao_data.pts/90000.0); @@ -189,7 +189,7 @@ } // return: delay in seconds between first and last sample in buffer -static float get_delay(){ +static float get_delay(void){ return 0.0; }