Mercurial > mplayer.hg
diff libao2/ao_nas.c @ 17566:f580a7755ac5
Patch by Stefan Huehner / stefan % huehner ! org \
patch replaces '()' for the correct '(void)' in function
declarations/prototypes which have no parameters. The '()' syntax tell
thats there is a variable list of arguments, so that the compiler cannot
check this. The extra CFLAG '-Wstrict-declarations' shows those cases.
Comments about a similar patch applied to ffmpeg:
That in C++ these mean the same, but in ANSI C the semantics are
different; function() is an (obsolete) K&R C style forward declaration,
it basically means that the function can have any number and any types
of parameters, effectively completely preventing the compiler from doing
any sort of type checking. -- Erik Slagter
Defining functions with unspecified arguments is allowed but bad.
With arguments unspecified the compiler can't report an error/warning
if the function is called with incorrect arguments. -- M\ns Rullg\rd
author | rathann |
---|---|
date | Thu, 09 Feb 2006 14:08:03 +0000 |
parents | 2beb7a7cdac1 |
children | 24ae1f262dc2 |
line wrap: on
line diff
--- a/libao2/ao_nas.c Thu Feb 09 10:23:51 2006 +0000 +++ b/libao2/ao_nas.c Thu Feb 09 14:08:03 2006 +0000 @@ -506,7 +506,7 @@ } // stop playing and empty buffers (for seeking/pause) -static void reset(){ +static void reset(void){ AuStatus as; mp_msg(MSGT_AO, MSGL_DBG3, "ao_nas: reset()\n"); @@ -523,7 +523,7 @@ } // stop playing, keep buffers (for pause) -static void audio_pause() +static void audio_pause(void) { AuStatus as; mp_msg(MSGT_AO, MSGL_DBG3, "ao_nas: audio_pause()\n"); @@ -532,7 +532,7 @@ } // resume playing, after audio_pause() -static void audio_resume() +static void audio_resume(void) { AuStatus as; @@ -546,7 +546,7 @@ // return: how many bytes can be played without blocking -static int get_space() +static int get_space(void) { int result; @@ -597,7 +597,7 @@ } // return: delay in seconds between first and last sample in buffer -static float get_delay() +static float get_delay(void) { float result;