diff libmpcodecs/native/xa_gsm.c @ 17566:f580a7755ac5

Patch by Stefan Huehner / stefan % huehner ! org \ patch replaces '()' for the correct '(void)' in function declarations/prototypes which have no parameters. The '()' syntax tell thats there is a variable list of arguments, so that the compiler cannot check this. The extra CFLAG '-Wstrict-declarations' shows those cases. Comments about a similar patch applied to ffmpeg: That in C++ these mean the same, but in ANSI C the semantics are different; function() is an (obsolete) K&R C style forward declaration, it basically means that the function can have any number and any types of parameters, effectively completely preventing the compiler from doing any sort of type checking. -- Erik Slagter Defining functions with unspecified arguments is allowed but bad. With arguments unspecified the compiler can't report an error/warning if the function is called with incorrect arguments. -- M���\ns Rullg���\rd

--- a/libmpcodecs/native/xa_gsm.c	Thu Feb 09 10:23:51 2006 +0000
+++ b/libmpcodecs/native/xa_gsm.c	Thu Feb 09 14:08:03 2006 +0000
@@ -40,7 +40,7 @@
 static XA_GSM_STATE gsm_state;
 
 
-void GSM_Init()
+void GSM_Init(void)
 {
   memset((char *)(&gsm_state), 0, sizeof(XA_GSM_STATE));
   gsm_state.nrp = 40;