Mercurial > mplayer.hg
diff libmpdemux/demux_ty_osd.c @ 17566:f580a7755ac5
Patch by Stefan Huehner / stefan % huehner ! org \
patch replaces '()' for the correct '(void)' in function
declarations/prototypes which have no parameters. The '()' syntax tell
thats there is a variable list of arguments, so that the compiler cannot
check this. The extra CFLAG '-Wstrict-declarations' shows those cases.
Comments about a similar patch applied to ffmpeg:
That in C++ these mean the same, but in ANSI C the semantics are
different; function() is an (obsolete) K&R C style forward declaration,
it basically means that the function can have any number and any types
of parameters, effectively completely preventing the compiler from doing
any sort of type checking. -- Erik Slagter
Defining functions with unspecified arguments is allowed but bad.
With arguments unspecified the compiler can't report an error/warning
if the function is called with incorrect arguments. -- M\ns Rullg\rd
author | rathann |
---|---|
date | Thu, 09 Feb 2006 14:08:03 +0000 |
parents | 6ff3379a0862 |
children | a8e681ad7c90 |
line wrap: on
line diff
--- a/libmpdemux/demux_ty_osd.c Thu Feb 09 10:23:51 2006 +0000 +++ b/libmpdemux/demux_ty_osd.c Thu Feb 09 14:08:03 2006 +0000 @@ -63,7 +63,7 @@ static int tyOSDInited = 0; static int tyOSDUpdate = 0; -static void ty_DrawOSD() +static void ty_DrawOSD(void) { // printf( "Calling ty_DrawOSD()\n" ); tyOSDUpdate = 1; @@ -161,7 +161,7 @@ *( TY_CC_ptr++ ) = ( c == 14 ) ? '/' : c; // swap a '/' for musical note } -static void ty_draw() +static void ty_draw(void) { if ( TY_CC_ptr != TY_CC_buf && TY_OSD_flags & TY_TEXT_MODE ) { @@ -513,7 +513,7 @@ } -static void ty_DisplayXDSInfo() +static void ty_DisplayXDSInfo(void) { int index; int size;